From: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
Qu Wenruo <wqu@suse.com>
Subject: Re: [PATCH v4 48/53] btrfs: do proper error handling in merge_reloc_roots
Date: Sun, 6 Dec 2020 17:10:14 -0500 [thread overview]
Message-ID: <20201206221013.GF31381@hungrycats.org> (raw)
In-Reply-To: <9ad2a3b417b1f54d75231b1c1a3b6531b9746f79.1607019557.git.josef@toxicpanda.com>
On Thu, Dec 03, 2020 at 01:22:54PM -0500, Josef Bacik wrote:
> We have a BUG_ON() if we get an error back from btrfs_get_fs_root().
> This honestly should never fail, as at this point we have a solid
> coordination of fs root to reloc root, and these roots will all be in
> memory. But in the name of killing BUG_ON()'s remove this one and
> handle the error properly. Change the remaining BUG_ON() to an
> ASSERT().
>
> Reviewed-by: Qu Wenruo <wqu@suse.com>
> Signed-off-by: Josef Bacik <josef@toxicpanda.com>
> ---
> fs/btrfs/relocation.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
> index 511cb7c31328..737fc5902901 100644
> --- a/fs/btrfs/relocation.c
> +++ b/fs/btrfs/relocation.c
> @@ -1949,9 +1949,19 @@ void merge_reloc_roots(struct reloc_control *rc)
>
> root = btrfs_get_fs_root(fs_info, reloc_root->root_key.offset,
> false);
> + if (IS_ERR(root)) {
> + /*
> + * This likely won't happen, since we would have failed
> + * at a higher level. However for correctness sake
> + * handle the error anyway.
> + */
> + ASSERT(0);
After a few days of running for-next + these patches on a test VM,
I am hitting this assert at mount:
[ 37.413799][ T3628] BTRFS info (device dm-0): enabling ssd optimizations
[ 37.415985][ T3628] BTRFS info (device dm-0): turning on flush-on-commit
[ 37.417712][ T3628] BTRFS info (device dm-0): turning on async discard
[ 37.419402][ T3628] BTRFS info (device dm-0): use zstd compression, level 3
[ 37.421153][ T3628] BTRFS info (device dm-0): using free space tree
[ 37.422807][ T3628] BTRFS info (device dm-0): has skinny extents
[ 75.372451][ T3628] assertion failed: 0, in fs/btrfs/relocation.c:1956
[ 75.374184][ T3628] ------------[ cut here ]------------
[ 75.375558][ T3628] kernel BUG at fs/btrfs/ctree.h:3367!
[ 75.377551][ T3628] invalid opcode: 0000 [#1] SMP KASAN PTI
[ 75.379303][ T3628] CPU: 2 PID: 3628 Comm: mount Not tainted 5.10.0-0ef9ce393ff3-misc-next+ #83
[ 75.382778][ T3628] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.12.0-1 04/01/2014
[ 75.385315][ T3628] RIP: 0010:assertfail+0x18/0x1a
[ 75.386627][ T3628] Code: 0f 35 aa fe 48 8b 3d 18 ac fd 02 e8 03 35 aa fe 5d c3 55 89 d1 48 89 f2 48 89 fe 48 c7 c7 60 1d 24 9d 48 89 e5 e8 e3 34 fe ff <0f> 0b 48 89 df e8 6f 19 b4 fe 48 8b 85 a8 fe ff ff 44 89 ea 48 c7
[ 75.393562][ T3628] RSP: 0018:ffffc900008274c0 EFLAGS: 00010282
[ 75.395637][ T3628] RAX: 0000000000000032 RBX: ffff8881213b6590 RCX: ffffffff9b265ba2
[ 75.398385][ T3628] RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffff8881f5bff28c
[ 75.401189][ T3628] RBP: ffffc900008274c0 R08: ffffed103eb815b5 R09: ffffed103eb815b5
[ 75.404282][ T3628] R10: ffff8881f5c0ada7 R11: ffffed103eb815b4 R12: ffff88810ab20000
[ 75.407136][ T3628] R13: ffff8881213b6000 R14: fffffffffffffffe R15: ffff88810ab20648
[ 75.409792][ T3628] FS: 00007faff8004100(0000) GS:ffff8881f5a00000(0000) knlGS:0000000000000000
[ 75.412870][ T3628] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 75.415193][ T3628] CR2: 000055d217ae2f48 CR3: 0000000107c84005 CR4: 0000000000170ee0
[ 75.418040][ T3628] Call Trace:
[ 75.419284][ T3628] merge_reloc_roots.cold.60+0x3a/0xd8
[ 75.420663][ T3628] ? merge_reloc_root+0xc10/0xc10
[ 75.421856][ T3628] btrfs_recover_relocation+0x5c6/0x940
[ 75.423181][ T3628] ? btrfs_relocate_block_group+0x4c0/0x4c0
[ 75.424444][ T3628] ? __kasan_check_write+0x14/0x20
[ 75.425534][ T3628] ? up_read+0x176/0x4f0
[ 75.426379][ T3628] ? down_write_nested+0x2d0/0x2d0
[ 75.427542][ T3628] btrfs_start_pre_rw_mount+0x12e/0x200
[ 75.429467][ T3628] open_ctree+0x2191/0x254f
[ 75.431474][ T3628] ? btrfs_get_root_ref.cold.76+0x2c/0x2c
[ 75.434053][ T3628] ? snprintf+0x91/0xc0
[ 75.435904][ T3628] btrfs_mount_root.cold.74+0xe/0xea
[ 75.438177][ T3628] ? parse_rescue_options+0x240/0x240
[ 75.440582][ T3628] ? rcu_read_lock_sched_held+0xa1/0xd0
[ 75.443018][ T3628] ? rcu_read_lock_bh_held+0xb0/0xb0
[ 75.445324][ T3628] ? legacy_parse_param+0x73/0x450
[ 75.447483][ T3628] ? vfs_parse_fs_string+0xa7/0x120
[ 75.449773][ T3628] ? kfree+0x1c1/0x200
[ 75.451504][ T3628] ? parse_rescue_options+0x240/0x240
[ 75.453938][ T3628] legacy_get_tree+0x89/0xd0
[ 75.455915][ T3628] vfs_get_tree+0x52/0x150
[ 75.457829][ T3628] fc_mount+0x14/0x60
[ 75.459703][ T3628] vfs_kern_mount.part.38+0x61/0xa0
[ 75.461989][ T3628] vfs_kern_mount+0x13/0x20
[ 75.463979][ T3628] btrfs_mount+0x1f0/0x5d0
[ 75.465844][ T3628] ? btrfs_show_options+0x8c0/0x8c0
[ 75.468146][ T3628] ? rcu_read_lock_sched_held+0xa1/0xd0
[ 75.470603][ T3628] ? check_flags+0x26/0x30
[ 75.472539][ T3628] ? lock_is_held_type+0xc3/0xf0
[ 75.474632][ T3628] ? rcu_read_lock_sched_held+0xa1/0xd0
[ 75.476960][ T3628] ? rcu_read_lock_bh_held+0xb0/0xb0
[ 75.479202][ T3628] ? legacy_parse_param+0x73/0x450
[ 75.481013][ T3628] ? vfs_parse_fs_string+0xa7/0x120
[ 75.482712][ T3628] ? cap_capable+0xd2/0x110
[ 75.484118][ T3628] ? btrfs_show_options+0x8c0/0x8c0
[ 75.485749][ T3628] legacy_get_tree+0x89/0xd0
[ 75.487689][ T3628] ? btrfs_show_options+0x8c0/0x8c0
[ 75.489907][ T3628] ? legacy_get_tree+0x89/0xd0
[ 75.491911][ T3628] vfs_get_tree+0x52/0x150
[ 75.493788][ T3628] path_mount+0xa53/0xf00
[ 75.495500][ T3628] ? __check_object_size+0x17e/0x220
[ 75.497042][ T3628] ? finish_automount+0x430/0x430
[ 75.498312][ T3628] ? getname_flags+0xfd/0x2b0
[ 75.499443][ T3628] do_mount+0xd2/0xf0
[ 75.500409][ T3628] ? path_mount+0xf00/0xf00
[ 75.501524][ T3628] ? __kasan_check_write+0x14/0x20
[ 75.502736][ T3628] __x64_sys_mount+0x100/0x120
[ 75.505056][ T3628] do_syscall_64+0x37/0x80
[ 75.506986][ T3628] entry_SYSCALL_64_after_hwframe+0x44/0xa9
[ 75.508426][ T3628] RIP: 0033:0x7faff8202fea
[ 75.509476][ T3628] Code: 48 8b 0d a9 0e 0c 00 f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 49 89 ca b8 a5 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 76 0e 0c 00 f7 d8 64 89 01 48
[ 75.514323][ T3628] RSP: 002b:00007ffe9b44e6c8 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
[ 75.517413][ T3628] RAX: ffffffffffffffda RBX: 000055a3e65d6b40 RCX: 00007faff8202fea
[ 75.520839][ T3628] RDX: 000055a3e65de650 RSI: 000055a3e65d6d90 RDI: 000055a3e65d6ef0
[ 75.524350][ T3628] RBP: 00007faff85501c4 R08: 000055a3e65d6e30 R09: 000055a3e65dea90
[ 75.527798][ T3628] R10: 0000000000000400 R11: 0000000000000246 R12: 0000000000000000
[ 75.531273][ T3628] R13: 0000000000000400 R14: 000055a3e65d6ef0 R15: 000055a3e65de650
[ 75.534685][ T3628] Modules linked in:
[ 75.536431][ T3628] ---[ end trace d5a13ffc3f4ddc24 ]---
[ 75.538742][ T3628] RIP: 0010:assertfail+0x18/0x1a
[ 75.540855][ T3628] Code: 0f 35 aa fe 48 8b 3d 18 ac fd 02 e8 03 35 aa fe 5d c3 55 89 d1 48 89 f2 48 89 fe 48 c7 c7 60 1d 24 9d 48 89 e5 e8 e3 34 fe ff <0f> 0b 48 89 df e8 6f 19 b4 fe 48 8b 85 a8 fe ff ff 44 89 ea 48 c7
[ 75.548258][ T3628] RSP: 0018:ffffc900008274c0 EFLAGS: 00010282
[ 75.551045][ T3628] RAX: 0000000000000032 RBX: ffff8881213b6590 RCX: ffffffff9b265ba2
[ 75.554619][ T3628] RDX: 0000000000000000 RSI: 0000000000000008 RDI: ffff8881f5bff28c
[ 75.557391][ T3628] RBP: ffffc900008274c0 R08: ffffed103eb815b5 R09: ffffed103eb815b5
[ 75.559640][ T3628] R10: ffff8881f5c0ada7 R11: ffffed103eb815b4 R12: ffff88810ab20000
[ 75.562663][ T3628] R13: ffff8881213b6000 R14: fffffffffffffffe R15: ffff88810ab20648
[ 75.565276][ T3628] FS: 00007faff8004100(0000) GS:ffff8881f5a00000(0000) knlGS:0000000000000000
[ 75.568147][ T3628] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 75.570715][ T3628] CR2: 000055d217ae2f48 CR3: 0000000107c84005 CR4: 0000000000170ee0
> + ret = PTR_ERR(root);
> + goto out;
> + }
> +
> if (btrfs_root_refs(&reloc_root->root_item) > 0) {
> - BUG_ON(IS_ERR(root));
> - BUG_ON(root->reloc_root != reloc_root);
> + ASSERT(root->reloc_root == reloc_root);
> ret = merge_reloc_root(rc, root);
> btrfs_put_root(root);
> if (ret) {
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-12-06 22:11 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 18:22 [PATCH v4 00/53] Cleanup error handling in relocation Josef Bacik
2020-12-03 18:22 ` [PATCH v4 01/53] btrfs: fix error handling in commit_fs_roots Josef Bacik
2020-12-03 18:22 ` [PATCH v4 02/53] btrfs: allow error injection for btrfs_search_slot and btrfs_cow_block Josef Bacik
2020-12-03 18:22 ` [PATCH v4 03/53] btrfs: modify the new_root highest_objectid under a ref count Josef Bacik
2020-12-04 8:01 ` Qu Wenruo
2020-12-07 8:35 ` Nikolay Borisov
2020-12-03 18:22 ` [PATCH v4 04/53] btrfs: fix lockdep splat in btrfs_recover_relocation Josef Bacik
2020-12-03 18:22 ` [PATCH v4 05/53] btrfs: keep track of the root owner for relocation reads Josef Bacik
2020-12-04 8:03 ` Qu Wenruo
2020-12-03 18:22 ` [PATCH v4 06/53] btrfs: noinline btrfs_should_cancel_balance Josef Bacik
2020-12-03 18:22 ` [PATCH v4 07/53] btrfs: do not cleanup upper nodes in btrfs_backref_cleanup_node Josef Bacik
2020-12-03 18:22 ` [PATCH v4 08/53] btrfs: pass down the tree block level through ref-verify Josef Bacik
2020-12-07 7:53 ` Johannes Thumshirn
2020-12-03 18:22 ` [PATCH v4 09/53] btrfs: make sure owner is set in ref-verify Josef Bacik
2020-12-03 18:22 ` [PATCH v4 10/53] btrfs: don't clear ret in btrfs_start_dirty_block_groups Josef Bacik
2020-12-03 18:22 ` [PATCH v4 11/53] btrfs: convert some BUG_ON()'s to ASSERT()'s in do_relocation Josef Bacik
2020-12-03 18:22 ` [PATCH v4 12/53] btrfs: convert BUG_ON()'s in relocate_tree_block Josef Bacik
2020-12-03 18:22 ` [PATCH v4 13/53] btrfs: return an error from btrfs_record_root_in_trans Josef Bacik
2020-12-03 18:22 ` [PATCH v4 14/53] btrfs: handle errors from select_reloc_root() Josef Bacik
2020-12-03 18:22 ` [PATCH v4 15/53] btrfs: convert BUG_ON()'s in select_reloc_root() to proper errors Josef Bacik
2020-12-04 8:04 ` Qu Wenruo
2020-12-03 18:22 ` [PATCH v4 16/53] btrfs: check record_root_in_trans related failures in select_reloc_root Josef Bacik
2020-12-03 18:22 ` [PATCH v4 17/53] btrfs: do proper error handling in record_reloc_root_in_trans Josef Bacik
2020-12-04 8:05 ` Qu Wenruo
2020-12-03 18:22 ` [PATCH v4 18/53] btrfs: handle btrfs_record_root_in_trans failure in btrfs_rename_exchange Josef Bacik
2020-12-03 18:22 ` [PATCH v4 19/53] btrfs: handle btrfs_record_root_in_trans failure in btrfs_rename Josef Bacik
2020-12-03 18:22 ` [PATCH v4 20/53] btrfs: handle btrfs_record_root_in_trans failure in btrfs_delete_subvolume Josef Bacik
2020-12-03 18:22 ` [PATCH v4 21/53] btrfs: handle btrfs_record_root_in_trans failure in btrfs_recover_log_trees Josef Bacik
2020-12-03 18:22 ` [PATCH v4 22/53] btrfs: handle btrfs_record_root_in_trans failure in create_subvol Josef Bacik
2020-12-03 18:22 ` [PATCH v4 23/53] btrfs: btrfs: handle btrfs_record_root_in_trans failure in relocate_tree_block Josef Bacik
2020-12-03 18:22 ` [PATCH v4 24/53] btrfs: handle btrfs_record_root_in_trans failure in start_transaction Josef Bacik
2020-12-03 18:22 ` [PATCH v4 25/53] btrfs: handle record_root_in_trans failure in qgroup_account_snapshot Josef Bacik
2020-12-03 18:22 ` [PATCH v4 26/53] btrfs: handle record_root_in_trans failure in btrfs_record_root_in_trans Josef Bacik
2020-12-03 18:22 ` [PATCH v4 27/53] btrfs: handle record_root_in_trans failure in create_pending_snapshot Josef Bacik
2020-12-03 18:22 ` [PATCH v4 28/53] btrfs: do not panic in __add_reloc_root Josef Bacik
2020-12-03 18:22 ` [PATCH v4 29/53] btrfs: have proper error handling in btrfs_init_reloc_root Josef Bacik
2020-12-03 18:22 ` [PATCH v4 30/53] btrfs: do proper error handling in create_reloc_root Josef Bacik
2020-12-03 18:22 ` [PATCH v4 31/53] btrfs: validate ->reloc_root after recording root in trans Josef Bacik
2020-12-03 18:22 ` [PATCH v4 32/53] btrfs: handle btrfs_update_reloc_root failure in commit_fs_roots Josef Bacik
2020-12-03 18:22 ` [PATCH v4 33/53] btrfs: change insert_dirty_subvol to return errors Josef Bacik
2020-12-03 18:22 ` [PATCH v4 34/53] btrfs: handle btrfs_update_reloc_root failure in insert_dirty_subvol Josef Bacik
2020-12-03 18:22 ` [PATCH v4 35/53] btrfs: handle btrfs_update_reloc_root failure in prepare_to_merge Josef Bacik
2020-12-03 18:22 ` [PATCH v4 36/53] btrfs: do proper error handling in btrfs_update_reloc_root Josef Bacik
2020-12-03 18:22 ` [PATCH v4 37/53] btrfs: convert logic BUG_ON()'s in replace_path to ASSERT()'s Josef Bacik
2020-12-03 18:22 ` [PATCH v4 38/53] btrfs: handle btrfs_cow_block errors in replace_path Josef Bacik
2020-12-03 18:22 ` [PATCH v4 39/53] btrfs: handle btrfs_search_slot failure " Josef Bacik
2020-12-03 18:22 ` [PATCH v4 40/53] btrfs: handle errors in reference count manipulation " Josef Bacik
2020-12-03 18:22 ` [PATCH v4 41/53] btrfs: handle extent reference errors in do_relocation Josef Bacik
2020-12-03 18:22 ` [PATCH v4 42/53] btrfs: check for BTRFS_BLOCK_FLAG_FULL_BACKREF being set improperly Josef Bacik
2020-12-03 18:22 ` [PATCH v4 43/53] btrfs: remove the extent item sanity checks in relocate_block_group Josef Bacik
2020-12-03 18:22 ` [PATCH v4 44/53] btrfs: do proper error handling in create_reloc_inode Josef Bacik
2020-12-03 18:22 ` [PATCH v4 45/53] btrfs: handle __add_reloc_root failures in btrfs_recover_relocation Josef Bacik
2020-12-03 18:22 ` [PATCH v4 46/53] btrfs: cleanup error handling in prepare_to_merge Josef Bacik
2020-12-03 18:22 ` [PATCH v4 47/53] btrfs: handle extent corruption with select_one_root properly Josef Bacik
2020-12-03 18:22 ` [PATCH v4 48/53] btrfs: do proper error handling in merge_reloc_roots Josef Bacik
2020-12-06 22:10 ` Zygo Blaxell [this message]
2020-12-07 1:11 ` Qu Wenruo
2020-12-08 2:39 ` Zygo Blaxell
2020-12-03 18:22 ` [PATCH v4 49/53] btrfs: check return value of btrfs_commit_transaction in relocation Josef Bacik
2020-12-03 18:22 ` [PATCH v4 50/53] btrfs: do not WARN_ON() if we can't find the reloc root Josef Bacik
2020-12-03 18:22 ` [PATCH v4 51/53] btrfs: print the actual offset in btrfs_root_name Josef Bacik
2020-12-03 18:22 ` [PATCH v4 52/53] btrfs: fix reloc root leak with 0 ref reloc roots on recovery Josef Bacik
2020-12-03 18:22 ` [PATCH v4 53/53] btrfs: splice remaining dirty_bg's onto the transaction dirty bg list Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206221013.GF31381@hungrycats.org \
--to=ce3g8jdj@umail.furryterror.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.