From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv3 00/35] SCSI result handling cleanup, part 1
Date: Mon, 7 Dec 2020 13:47:44 +0100 [thread overview]
Message-ID: <20201207124819.95822-1-hare@suse.de> (raw)
Hi all,
this is the first part of an attempt to clean up SCSI result handling.
The patchset primarily cleans up various drivers by fixing up
whitespaces or move to standard definitions.
It also fixes some minor issues in some drivers which set the
wrong result values.
And, of course, another attempt to kill the gdth driver
I have a larger patchset based on this one to update the SCSI result
handling for all drivers, but decided to split things in two to not
overload reviewers
As usual, comments and reviews are welcome.
Changes to v1:
- Add reviews from Christoph
- Included review from Finn Thain
- Add set_status_byte() helper
- Add cleanup for dc395c
- Add additional patch for using SAM status values instead
of the shifted linux versions
Changes to v2:
- Add Reviewed-by: tags
- Drop additional patches again
Hannes Reinecke (35):
scsi: drop gdth driver
3w-xxxx: Whitespace cleanup
3w-9xxx: Whitespace cleanup
3w-sas: Whitespace cleanup
atp870u: Whitespace cleanup
aic7xxx,aic79xx: Whitespace cleanup
aic7xxx,aic79xx: kill pointless forward declarations
aic7xxx,aic79xxx: remove driver-defined SAM status definitions
bfa: drop driver-defined SCSI status codes
acornscsi: use standard defines
nsp32: fixup status handling
dc395: drop private SAM status code definitions
qla4xxx: use standard SAM status definitions
zfcp: do not set COMMAND_COMPLETE
aacraid: avoid setting message byte on completion
hpsa: do not set COMMAND_COMPLETE
stex: do not set COMMAND_COMPLETE
nsp_cs: drop internal SCSI message definition
aic7xxx,aic79xx: drop internal SCSI message definition
dc395x: drop internal SCSI message definitions
initio: drop internal SCSI message definition
scsi_debug: do not set COMMAND_COMPLETE
ufshcd: do not set COMMAND_COMPLETE
atp870u: use standard definitions
mac53c94: Do not set invalid command result
dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message
scsi: add 'set_status_byte()' accessor
esp_scsi: use host byte as last argument to esp_cmd_is_done()
esp_scsi: do not set SCSI message byte
wd33c93: use SCSI status
ips: use correct command completion on error
storvsc: Return DID_ERROR for invalid commands
qla2xxx: fc_remote_port_chkready() returns a SCSI result value
advansys: kill driver_defined status byte accessors
ncr53c8xx: Use SAM status values
Documentation/kbuild/makefiles.rst | 4 +-
Documentation/process/magic-number.rst | 2 -
Documentation/scsi/scsi-parameters.rst | 3 -
Documentation/userspace-api/ioctl/ioctl-number.rst | 1 -
drivers/s390/scsi/zfcp_fc.h | 1 -
drivers/scsi/3w-9xxx.c | 56 +-
drivers/scsi/3w-9xxx.h | 156 +-
drivers/scsi/3w-sas.c | 52 +-
drivers/scsi/3w-sas.h | 118 +-
drivers/scsi/3w-xxxx.c | 251 +-
drivers/scsi/3w-xxxx.h | 199 +-
drivers/scsi/Kconfig | 14 -
drivers/scsi/Makefile | 2 -
drivers/scsi/aacraid/aachba.c | 173 +-
drivers/scsi/advansys.c | 84 +-
drivers/scsi/aic7xxx/aic79xx.h | 36 +-
drivers/scsi/aic7xxx/aic79xx_core.c | 257 +-
drivers/scsi/aic7xxx/aic79xx_osm.c | 20 +-
drivers/scsi/aic7xxx/aic79xx_osm.h | 37 +-
drivers/scsi/aic7xxx/aic79xx_osm_pci.c | 6 +-
drivers/scsi/aic7xxx/aic79xx_proc.c | 13 +-
drivers/scsi/aic7xxx/aic7xxx_93cx6.c | 4 +-
drivers/scsi/aic7xxx/aic7xxx_core.c | 263 +-
drivers/scsi/aic7xxx/aic7xxx_osm.c | 88 +-
drivers/scsi/aic7xxx/aic7xxx_osm.h | 39 +-
drivers/scsi/aic7xxx/aic7xxx_proc.c | 15 +-
drivers/scsi/aic7xxx/aiclib.h | 15 -
drivers/scsi/aic7xxx/scsi_message.h | 41 -
drivers/scsi/arm/acornscsi.c | 14 +-
drivers/scsi/atp870u.c | 451 +-
drivers/scsi/atp870u.h | 14 +-
drivers/scsi/bfa/bfa_fc.h | 15 -
drivers/scsi/bfa/bfa_fcpim.c | 2 +-
drivers/scsi/bfa/bfad_im.c | 2 +-
drivers/scsi/dc395x.c | 25 +-
drivers/scsi/dc395x.h | 38 -
drivers/scsi/dpt_i2o.c | 2 +-
drivers/scsi/esp_scsi.c | 23 +-
drivers/scsi/gdth.c | 4322 --------------------
drivers/scsi/gdth.h | 981 -----
drivers/scsi/gdth_ioctl.h | 251 --
drivers/scsi/gdth_proc.c | 586 ---
drivers/scsi/gdth_proc.h | 18 -
drivers/scsi/hpsa.c | 4 +-
drivers/scsi/initio.c | 64 +-
drivers/scsi/initio.h | 25 -
drivers/scsi/ips.c | 9 +-
drivers/scsi/mac53c94.c | 1 -
drivers/scsi/ncr53c8xx.c | 83 +-
drivers/scsi/ncr53c8xx.h | 16 -
drivers/scsi/nsp32.c | 2 +-
drivers/scsi/pcmcia/nsp_cs.c | 12 +-
drivers/scsi/pcmcia/nsp_cs.h | 11 -
drivers/scsi/qla2xxx/qla_os.c | 2 +-
drivers/scsi/qla4xxx/ql4_fw.h | 1 -
drivers/scsi/qla4xxx/ql4_isr.c | 2 +-
drivers/scsi/scsi_debug.c | 2 +-
drivers/scsi/stex.c | 25 +-
drivers/scsi/storvsc_drv.c | 2 +-
drivers/scsi/ufs/ufshcd.c | 4 +-
drivers/scsi/wd33c93.c | 6 +-
include/scsi/scsi.h | 1 +
include/scsi/scsi_cmnd.h | 5 +
63 files changed, 1305 insertions(+), 7666 deletions(-)
delete mode 100644 drivers/scsi/gdth.c
delete mode 100644 drivers/scsi/gdth.h
delete mode 100644 drivers/scsi/gdth_ioctl.h
delete mode 100644 drivers/scsi/gdth_proc.c
delete mode 100644 drivers/scsi/gdth_proc.h
--
2.16.4
next reply other threads:[~2020-12-07 12:49 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 12:47 Hannes Reinecke [this message]
2020-12-07 12:47 ` [PATCH 01/35] scsi: drop gdth driver Hannes Reinecke
2020-12-07 13:38 ` Christoph Hellwig
2020-12-07 14:01 ` Hannes Reinecke
2020-12-07 12:47 ` [PATCH 02/35] 3w-xxxx: Whitespace cleanup Hannes Reinecke
2020-12-07 12:47 ` [PATCH 03/35] 3w-9xxx: " Hannes Reinecke
2020-12-07 12:47 ` [PATCH 04/35] 3w-sas: " Hannes Reinecke
2020-12-07 12:47 ` [PATCH 05/35] atp870u: " Hannes Reinecke
2020-12-07 12:47 ` [PATCH 06/35] aic7xxx,aic79xx: " Hannes Reinecke
2020-12-07 12:47 ` [PATCH 07/35] aic7xxx,aic79xx: kill pointless forward declarations Hannes Reinecke
2020-12-07 12:47 ` [PATCH 08/35] aic7xxx,aic79xxx: remove driver-defined SAM status definitions Hannes Reinecke
2020-12-07 12:47 ` [PATCH 09/35] bfa: drop driver-defined SCSI status codes Hannes Reinecke
2020-12-07 12:47 ` [PATCH 10/35] acornscsi: use standard defines Hannes Reinecke
2020-12-07 12:47 ` [PATCH 11/35] nsp32: fixup status handling Hannes Reinecke
2020-12-07 12:47 ` [PATCH 12/35] dc395: drop private SAM status code definitions Hannes Reinecke
2020-12-07 12:47 ` [PATCH 13/35] qla4xxx: use standard SAM status definitions Hannes Reinecke
2020-12-07 12:47 ` [PATCH 14/35] zfcp: do not set COMMAND_COMPLETE Hannes Reinecke
2020-12-07 12:47 ` [PATCH 15/35] aacraid: avoid setting message byte on completion Hannes Reinecke
2020-12-07 12:48 ` [PATCH 16/35] hpsa: do not set COMMAND_COMPLETE Hannes Reinecke
2020-12-07 12:48 ` [PATCH 17/35] stex: " Hannes Reinecke
2020-12-07 12:48 ` [PATCH 18/35] nsp_cs: drop internal SCSI message definition Hannes Reinecke
2020-12-07 12:48 ` [PATCH 19/35] aic7xxx,aic79xx: " Hannes Reinecke
2020-12-07 12:48 ` [PATCH 20/35] dc395x: drop internal SCSI message definitions Hannes Reinecke
2020-12-18 8:58 ` kernel test robot
2020-12-18 8:58 ` kernel test robot
2020-12-07 12:48 ` [PATCH 21/35] initio: drop internal SCSI message definition Hannes Reinecke
2020-12-07 12:48 ` [PATCH 22/35] scsi_debug: do not set COMMAND_COMPLETE Hannes Reinecke
2020-12-07 12:48 ` [PATCH 23/35] ufshcd: " Hannes Reinecke
2020-12-07 12:48 ` [PATCH 24/35] atp870u: use standard definitions Hannes Reinecke
2020-12-07 12:48 ` [PATCH 25/35] mac53c94: Do not set invalid command result Hannes Reinecke
2020-12-07 12:48 ` [PATCH 26/35] dpt_i2o: use DID_ERROR instead of INITIATOR_ERROR message Hannes Reinecke
2020-12-07 12:48 ` [PATCH 27/35] scsi: add 'set_status_byte()' accessor Hannes Reinecke
2020-12-07 12:48 ` [PATCH 28/35] esp_scsi: use host byte as last argument to esp_cmd_is_done() Hannes Reinecke
2020-12-07 12:48 ` [PATCH 29/35] esp_scsi: do not set SCSI message byte Hannes Reinecke
2020-12-07 12:48 ` [PATCH 30/35] wd33c93: use SCSI status Hannes Reinecke
2020-12-07 12:48 ` [PATCH 31/35] ips: use correct command completion on error Hannes Reinecke
2020-12-07 12:48 ` [PATCH 32/35] storvsc: Return DID_ERROR for invalid commands Hannes Reinecke
2020-12-07 12:48 ` [PATCH 33/35] qla2xxx: fc_remote_port_chkready() returns a SCSI result value Hannes Reinecke
2020-12-07 12:48 ` [PATCH 34/35] advansys: kill driver_defined status byte accessors Hannes Reinecke
2020-12-07 12:48 ` [PATCH 35/35] ncr53c8xx: Use SAM status values Hannes Reinecke
2021-01-13 9:04 [PATCHv4 00/35] [PATCHv3 00/35] SCSI result handling cleanup, part 1 Hannes Reinecke
2021-01-27 4:54 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201207124819.95822-1-hare@suse.de \
--to=hare@suse.de \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.