Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh@kernel.org>, Jean Delvare <jdelvare@suse.com>,
	Jonathan Corbet <corbet@lwn.net>,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>,
	Kun Yi <kunyi@google.com>
Subject: Re: [PATCH 4/4] dt-bindings: hwmon: convert AD ADM1275 bindings to dt-schema
Date: Tue, 8 Dec 2020 09:13:50 +0100	[thread overview]
Message-ID: <20201208081350.GA5088@kozik-lap> (raw)
In-Reply-To: <20201208001916.GA59429@roeck-us.net>

On Mon, Dec 07, 2020 at 04:19:16PM -0800, Guenter Roeck wrote:
> On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote:
> > On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote:
> > > Convert the Analog Devices ADM1275 bindings to dt-schema.
> > > 
> > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > > ---
> > >  .../bindings/hwmon/adi,adm1275.yaml           | 58 +++++++++++++++++++
> > >  .../devicetree/bindings/hwmon/adm1275.txt     | 25 --------
> > >  Documentation/hwmon/adm1275.rst               |  2 +-
> > >  3 files changed, 59 insertions(+), 26 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt
> > > 
> > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > > new file mode 100644
> > > index 000000000000..2cad28c499dc
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml
> > > @@ -0,0 +1,58 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +
> > > +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors
> > > +
> > > +maintainers:
> > > +  - Krzysztof Kozlowski <krzk@kernel.org>
> > > +
> > > +description: |
> > > +  The ADM1293 and ADM1294 are high accuracy integrated digital power monitors
> > > +  that offer digital current, voltage, and power monitoring using an on-chip,
> > > +  12-bit analog-to-digital converter (ADC), communicated through a PMBus
> > > +  compliant I2C interface.
> > > +
> > > +  Datasheets:
> > > +    https://www.analog.com/en/products/adm1294.html
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - adi,adm1075
> > > +      - adi,adm1272
> > > +      - adi,adm1275
> > > +      - adi,adm1276
> > > +      - adi,adm1278
> > > +      - adi,adm1293
> > > +      - adi,adm1294
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  shunt-resistor-micro-ohms:
> > > +    description:
> > > +      Shunt resistor value in micro-Ohm.
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > 
> > Don't need a type if you have units. With that dropped,
> > 
> 
> Sorry, I am not familiar with the terminology. Does that refer to
> the '$ref' line ?

Yes, it's the $ref line which can be safely removed. The core dt-schema
applies such $ref if the property name ends with '-micro-ohms'.

Best regards,
Krzysztof