From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: <gregkh@linuxfoundation.org>
Cc: <linux-usb@vger.kernel.org>,
Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
Tejas Joglekar <joglekar@synopsys.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>
Subject: [PATCH 1/5] usb: xhci: Set quirk for XHCI_SG_TRB_CACHE_SIZE_QUIRK
Date: Tue, 8 Dec 2020 11:29:08 +0200 [thread overview]
Message-ID: <20201208092912.1773650-2-mathias.nyman@linux.intel.com> (raw)
In-Reply-To: <20201208092912.1773650-1-mathias.nyman@linux.intel.com>
From: Tejas Joglekar <Tejas.Joglekar@synopsys.com>
This commit uses the private data passed by parent device
to set the quirk for Synopsys xHC. This patch fixes the
SNPS xHC hang issue when the data is scattered across
small buffers which does not make atleast MPS size for
given TRB cache size of SNPS xHC.
Signed-off-by: Tejas Joglekar <joglekar@synopsys.com>
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
---
drivers/usb/host/xhci-plat.c | 3 +++
drivers/usb/host/xhci.h | 1 +
2 files changed, 4 insertions(+)
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
index aa2d35f98200..4d34f6005381 100644
--- a/drivers/usb/host/xhci-plat.c
+++ b/drivers/usb/host/xhci-plat.c
@@ -333,6 +333,9 @@ static int xhci_plat_probe(struct platform_device *pdev)
if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
hcd->skip_phy_initialization = 1;
+ if (priv && (priv->quirks & XHCI_SG_TRB_CACHE_SIZE_QUIRK))
+ xhci->quirks |= XHCI_SG_TRB_CACHE_SIZE_QUIRK;
+
ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
if (ret)
goto disable_usb_phy;
diff --git a/drivers/usb/host/xhci.h b/drivers/usb/host/xhci.h
index ebb359ebb261..d90c0d5df3b3 100644
--- a/drivers/usb/host/xhci.h
+++ b/drivers/usb/host/xhci.h
@@ -1878,6 +1878,7 @@ struct xhci_hcd {
#define XHCI_RENESAS_FW_QUIRK BIT_ULL(36)
#define XHCI_SKIP_PHY_INIT BIT_ULL(37)
#define XHCI_DISABLE_SPARSE BIT_ULL(38)
+#define XHCI_SG_TRB_CACHE_SIZE_QUIRK BIT_ULL(39)
unsigned int num_active_eps;
unsigned int limit_active_eps;
--
2.25.1
next prev parent reply other threads:[~2020-12-08 9:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 9:29 [PATCH 0/5] xhci features for usb-next Mathias Nyman
2020-12-08 9:29 ` Mathias Nyman [this message]
2020-12-08 9:29 ` [PATCH 2/5] usb: xhci: Use temporary buffer to consolidate SG Mathias Nyman
2020-12-08 9:29 ` [PATCH 3/5] xhci-pci: Allow host runtime PM as default for Intel Alpine Ridge LP Mathias Nyman
2020-12-08 9:29 ` [PATCH 4/5] xhci-pci: Allow host runtime PM as default for Intel Maple Ridge xHCI Mathias Nyman
2020-12-08 9:39 ` Greg KH
2020-12-08 11:21 ` Mathias Nyman
2020-12-08 9:29 ` [PATCH 5/5] xhci: Give USB2 ports time to enter U3 in bus suspend Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208092912.1773650-2-mathias.nyman@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=Tejas.Joglekar@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=joglekar@synopsys.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.