From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Daniel Wagner <dwagner@suse.de>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Mike Galbraith <efault@gmx.de>,
Christoph Hellwig <hch@infradead.org>,
Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>
Subject: Re: [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq
Date: Tue, 8 Dec 2020 12:49:36 +0100 [thread overview]
Message-ID: <20201208114936.sfe2jpmbjulcpyjk@linutronix.de> (raw)
In-Reply-To: <20201208113653.awqz4zggmy37vbog@beryllium.lan>
On 2020-12-08 12:36:53 [+0100], Daniel Wagner wrote:
> Obvious in this configuration there are no remote completions (verified
> it).
do you complete on a remote CPU if you limit the queues to one (this is
untested of course)?
diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 3be352403839a..f35224a64a56e 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -2126,7 +2126,7 @@ static int nvme_setup_io_queues(struct nvme_dev *dev)
* If tags are shared with admin queue (Apple bug), then
* make sure we only use one IO queue.
*/
- if (dev->ctrl.quirks & NVME_QUIRK_SHARED_TAGS)
+ if (1 || dev->ctrl.quirks & NVME_QUIRK_SHARED_TAGS)
nr_io_queues = 1;
else
nr_io_queues = min(nvme_max_io_queues(dev),
> Thanks,
> Daniel
Sebastian
next prev parent reply other threads:[~2020-12-08 11:50 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-04 19:13 [PATCH 0/3 v2] blk-mq: Don't complete in IRQ, use llist_head Sebastian Andrzej Siewior
2020-12-04 19:13 ` [PATCH 1/3] blk-mq: Don't complete on a remote CPU in force threaded mode Sebastian Andrzej Siewior
2020-12-08 13:10 ` Christoph Hellwig
2020-12-04 19:13 ` [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq Sebastian Andrzej Siewior
2020-12-07 23:52 ` Jens Axboe
2020-12-08 8:22 ` Sebastian Andrzej Siewior
2020-12-08 8:44 ` Daniel Wagner
2020-12-08 11:36 ` Daniel Wagner
2020-12-08 11:49 ` Sebastian Andrzej Siewior [this message]
2020-12-08 12:41 ` Daniel Wagner
2020-12-08 12:52 ` Sebastian Andrzej Siewior
2020-12-08 12:57 ` Sebastian Andrzej Siewior
2020-12-08 13:27 ` Daniel Wagner
2020-12-17 16:45 ` Jens Axboe
2020-12-17 16:49 ` Daniel Wagner
2020-12-17 16:54 ` Jens Axboe
2020-12-08 13:13 ` Christoph Hellwig
2020-12-17 16:43 ` Sebastian Andrzej Siewior
2020-12-17 16:55 ` Jens Axboe
2020-12-17 16:58 ` Sebastian Andrzej Siewior
2020-12-17 17:05 ` Daniel Wagner
2020-12-17 18:16 ` Daniel Wagner
2020-12-17 18:22 ` Jens Axboe
2020-12-17 18:41 ` Daniel Wagner
2020-12-17 18:46 ` Jens Axboe
2020-12-17 19:07 ` Daniel Wagner
2020-12-17 19:13 ` Jens Axboe
2020-12-17 19:15 ` Daniel Wagner
2020-12-04 19:13 ` [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done Sebastian Andrzej Siewior
2020-12-08 13:20 ` Christoph Hellwig
2020-12-08 13:28 ` Christoph Hellwig
2020-12-14 20:20 ` Sebastian Andrzej Siewior
-- strict thread matches above, loose matches on Subject: below --
2021-01-23 20:10 [PATCH v3 0/3] blk-mq: Don't complete in IRQ, use llist_head Sebastian Andrzej Siewior
2021-01-23 20:10 ` [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq Sebastian Andrzej Siewior
2021-01-25 7:10 ` Hannes Reinecke
2021-01-25 8:25 ` Christoph Hellwig
2021-01-25 8:30 ` Sebastian Andrzej Siewior
2021-01-25 8:32 ` Christoph Hellwig
2021-01-25 9:29 ` Sebastian Andrzej Siewior
2021-01-25 8:22 ` Christoph Hellwig
2021-01-25 8:49 ` Christoph Hellwig
2021-01-27 11:22 ` Daniel Wagner
2020-10-28 6:56 [PATCH RFC] blk-mq: Don't IPI requests on PREEMPT_RT Christoph Hellwig
2020-10-28 14:12 ` [PATCH 1/3] blk-mq: Don't complete on a remote CPU in force threaded mode Sebastian Andrzej Siewior
2020-10-28 14:12 ` [PATCH 2/3] blk-mq: Always complete remote completions requests in softirq Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208114936.sfe2jpmbjulcpyjk@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=axboe@kernel.dk \
--cc=dwagner@suse.de \
--cc=efault@gmx.de \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=sagi@grimberg.me \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.