From: Kees Cook <keescook@chromium.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: linux-kselftest@vger.kernel.org, shuah@kernel.org,
kuba@kernel.org, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH] selftests/harness: pass variant to teardown
Date: Fri, 11 Dec 2020 10:15:18 -0800 [thread overview]
Message-ID: <202012111013.46FEA48C@keescook> (raw)
In-Reply-To: <20201210231010.420298-1-willemdebruijn.kernel@gmail.com>
On Thu, Dec 10, 2020 at 06:10:10PM -0500, Willem de Bruijn wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> FIXTURE_VARIANT data is passed to FIXTURE_SETUP and TEST_F as variant.
>
> In some cases, the variant will change the setup, such that expections
> also change on teardown. Also pass variant to FIXTURE_TEARDOWN.
>
> The new FIXTURE_TEARDOWN logic is identical to that in FIXTURE_SETUP,
> right above.
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Thanks! This was on my TODO list. :)
Acked-by: Kees Cook <keescook@chromium.org>
--
Kees Cook
next prev parent reply other threads:[~2020-12-11 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 23:10 [PATCH] selftests/harness: pass variant to teardown Willem de Bruijn
2020-12-11 0:26 ` Jakub Kicinski
2020-12-11 18:15 ` Kees Cook [this message]
2021-02-06 3:11 ` Willem de Bruijn
2021-02-10 20:57 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012111013.46FEA48C@keescook \
--to=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.