From: Jakub Kicinski <kuba@kernel.org>
To: Eelco Chaudron <echaudro@redhat.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dev@openvswitch.org,
pshelar@ovn.org, bindiyakurle@gmail.com,
mcroce@linux.microsoft.com
Subject: Re: [PATCH net v2] net: openvswitch: fix TTL decrement exception action execution
Date: Mon, 14 Dec 2020 18:15:22 -0800 [thread overview]
Message-ID: <20201214181522.6279fbaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <160733569860.3007.12938188180387116741.stgit@wsfd-netdev64.ntdv.lab.eng.bos.redhat.com>
On Mon, 7 Dec 2020 05:08:39 -0500 Eelco Chaudron wrote:
> Currently, the exception actions are not processed correctly as the wrong
> dataset is passed. This change fixes this, including the misleading
> comment.
>
> In addition, a check was added to make sure we work on an IPv4 packet,
> and not just assume if it's not IPv6 it's IPv4.
>
> This was all tested using OVS with patch,
> https://patchwork.ozlabs.org/project/openvswitch/list/?series=21639,
> applied and sending packets with a TTL of 1 (and 0), both with IPv4
> and IPv6.
>
> Fixes: 69929d4c49e1 ("net: openvswitch: fix TTL decrement action netlink message format")
> Signed-off-by: Eelco Chaudron <echaudro@redhat.com>
> ---
> v2: - Undid unnessesary paramerter removal from dec_ttl_exception_handler()
> - Updated commit message to include testing information.
Applied now, and will send to stable soon-ish.
Thanks!
prev parent reply other threads:[~2020-12-15 2:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 10:08 [PATCH net v2] net: openvswitch: fix TTL decrement exception action execution Eelco Chaudron
2020-12-15 2:15 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201214181522.6279fbaa@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=bindiyakurle@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=echaudro@redhat.com \
--cc=mcroce@linux.microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@ovn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.