Re: [PATCH v2] trace-cmd: Re-enable the build of KernelShark v1

From: Steven Rostedt <rostedt@goodmis.org>
To: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Cc: linux-trace-devel@vger.kernel.org
Subject: Re: [PATCH v2] trace-cmd: Re-enable the build of KernelShark v1
Date: Wed, 16 Dec 2020 17:19:44 -0500	[thread overview]
Message-ID: <20201216171944.230cc08a@gandalf.local.home> (raw)
In-Reply-To: <20201216152850.7cf69fc8@gandalf.local.home>

On Wed, 16 Dec 2020 15:28:50 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 16 Dec 2020 15:07:15 +0200
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
> 
> > --- a/lib/traceevent/parse-utils.c
> > +++ b/lib/traceevent/parse-utils.c
> > @@ -9,8 +9,6 @@
> >  #include <stdarg.h>
> >  #include <errno.h>
> >  
> > -#include "event-utils.h"
> > -
> >  #define __weak __attribute__((weak))
> >  
> >  void __vwarning(const char *fmt, va_list ap)
> > --   
> 
> Is this needed?
> 
> I removed this hunk, and it still builds fine for me. After I did the
> dependency change mentioned in the other email.

I was building without libtraceevent installed, and it worked for me. But I
see why you did this. After installing libtraceevent on my host, I get:

( cc -c  -g -Wall -DVSOCK -D_GNU_SOURCE -DWARN_NO_AUDIT -DNO_AUDIT -I/work/git/trace-cmd.git/include -I/work/git/trace-cmd.git/../../include -I/work/git/trace-cmd.git/include/trace-cmd -I/work/git/trace-cmd.git/lib/trace-cmd/include -I/work/git/trace-cmd.git/lib/trace-cmd/include/private -I/work/git/trace-cmd.git/tracecmd/include -I/usr/local/include/traceevent  -I/usr/local/include/tracefs  -DVAR_DIR="/var" '-DPLUGIN_TRACEEVENT_DIR="/usr/local/lib64/traceevent/plugins"' '-DPLUGIN_TRACECMD_DIR=""'   -DHAVE_BLK_TC_FLUSH -I/work/git/trace-cmd.git/lib/traceevent/include -std=gnu99 -fPIC parse-utils.c -o /work/git/trace-cmd.git/lib/traceevent/parse-utils.o)
parse-utils.c:16:6: error: conflicting types for ‘__vwarning’
   16 | void __vwarning(const char *fmt, va_list ap)
      |      ^~~~~~~~~~
In file included from parse-utils.c:12:
/usr/local/include/traceevent/event-utils.h:20:6: note: previous declaration of ‘__vwarning’ was here
   20 | void __vwarning(const char *fmt, ...);
      |      ^~~~~~~~~~
parse-utils.c:41:6: error: conflicting types for ‘__vpr_stat’
   41 | void __vpr_stat(const char *fmt, va_list ap)
      |      ^~~~~~~~~~
In file included from parse-utils.c:12:
/usr/local/include/traceevent/event-utils.h:21:6: note: previous declaration of ‘__vpr_stat’ was here
   21 | void __vpr_stat(const char *fmt, ...);
      |      ^~~~~~~~~~
make[1]: *** [Makefile:50: /work/git/trace-cmd.git/lib/traceevent/parse-utils.o] Error 1
make: *** [Makefile:363: /work/git/trace-cmd.git/lib/traceevent/libtraceevent.a] Error 2

Ideally, we don't want to include the libtraceevent or libtracefs system
includes when building locally. Let me see if I can fix the make file here.

-- Steve