From: Christoph Hellwig <hch@infradead.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Souptick Joarder <jrdr.linux@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Alex Shi <alex.shi@linux.alibaba.com>
Subject: Re: [PATCH] mm: add prototype for __add_to_page_cache_locked()
Date: Wed, 23 Dec 2020 15:52:54 +0000 [thread overview]
Message-ID: <20201223155254.GA6138@infradead.org> (raw)
In-Reply-To: <20201223121136.GP874@casper.infradead.org>
On Wed, Dec 23, 2020 at 12:11:36PM +0000, Matthew Wilcox wrote:
> On Wed, Dec 23, 2020 at 08:31:26AM +0000, Christoph Hellwig wrote:
> > Can we please make the eBPF code stop referencing this function instead
> > of papering over this crap? It has no business poking into page cache
> > internals.
>
> The reference from the BPF code is simply "you can inject errors here".
> And I think we want to be able to inject errors to test the error paths,
> no?
Something that expects a symbol to be global is just pretty broken.
I think it need to change so that whatever instrumentation is done can
coexist with a static function.
next prev parent reply other threads:[~2020-12-23 15:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 14:19 [PATCH] mm: add prototype for __add_to_page_cache_locked() Souptick Joarder
2020-12-22 20:40 ` Matthew Wilcox
2020-12-22 23:53 ` Andrew Morton
2020-12-23 1:19 ` Matthew Wilcox
2020-12-23 8:31 ` Christoph Hellwig
2020-12-23 12:11 ` Matthew Wilcox
2020-12-23 15:52 ` Christoph Hellwig [this message]
2020-12-28 0:59 ` Alexei Starovoitov
2020-12-28 0:59 ` Alexei Starovoitov
2020-12-23 3:16 Souptick Joarder
2020-12-23 3:18 ` Souptick Joarder
2020-12-23 3:18 ` Souptick Joarder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201223155254.GA6138@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@linux.alibaba.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.