Re: [PATCH v3 1/3] dt-bindings: hwmon: Add TI TPS23861 bindings

From: Rob Herring <robh@kernel.org>
To: Robert Marko <robert.marko@sartura.hr>
Cc: jdelvare@suse.com, linux@roeck-us.net,
	linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Luka Perkov <luka.perkov@sartura.hr>
Subject: Re: [PATCH v3 1/3] dt-bindings: hwmon: Add TI TPS23861 bindings
Date: Sun, 3 Jan 2021 09:39:36 -0700	[thread overview]
Message-ID: <20210103163936.GA4009325@robh.at.kernel.org> (raw)
In-Reply-To: <20201222143012.1618807-1-robert.marko@sartura.hr>

On Tue, Dec 22, 2020 at 03:30:10PM +0100, Robert Marko wrote:
> Document bindings for the Texas Instruments TPS23861 driver.
> 
> Signed-off-by: Robert Marko <robert.marko@sartura.hr>
> Cc: Luka Perkov <luka.perkov@sartura.hr>
> ---
>  .../bindings/hwmon/ti,tps23861.yaml           | 53 +++++++++++++++++++
>  1 file changed, 53 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml
> 
> diff --git a/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml
> new file mode 100644
> index 000000000000..a7a801f54398
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/ti,tps23861.yaml
> @@ -0,0 +1,53 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/hwmon/ti,tps23861.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI TPS23861 PoE PSE
> +
> +maintainers:
> +  - Robert Marko <robert.marko@sartura.hr>
> +
> +description: |
> +  The TPS23861 is a IEEE 802.3at Quad Port Power-over-Ethernet PSE Controller.
> +
> +  Datasheets:
> +  https://www.ti.com/lit/gpn/tps23861
> +
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ti,tps23861
> +
> +  reg:
> +    maxItems: 1
> +
> +  shunt-resistor-micro-ohms:
> +    description: |
> +      The value of curent sense resistor in microohms.

s/curent/current/

> +    items:

Drop 'items', not an array.

> +      default: 255000
> +      minimum: 250000
> +      maximum: 255000
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +          #address-cells = <1>;
> +          #size-cells = <0>;
> +
> +          tps23861@30 {
> +              compatible = "ti,tps23861";
> +              reg = <0x30>;
> +              shunt-resistor-micro-ohms = <255000>;
> +          };
> +    };
> -- 
> 2.29.2
> 