From: Christoph Hellwig <hch@lst.de>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs
Date: Mon, 4 Jan 2021 09:55:35 +0100 [thread overview]
Message-ID: <20210104085535.GB28949@lst.de> (raw)
In-Reply-To: <20201230003255.3450874-4-ming.lei@redhat.com>
On Wed, Dec 30, 2020 at 08:32:52AM +0800, Ming Lei wrote:
> The inline bvecs won't be used if user needn't bvecs by not passing
> BIOSET_NEED_BVECS, so don't allocate bvecs in this situation.
Looks sensible.
> - bs->bio_slab = bio_find_or_create_slab(front_pad + back_pad);
> + bs->bio_slab = bio_find_or_create_slab(bs->front_pad + bs->back_pad);
Passing the bioset to bio_find_or_create_slab and returning an errno
might be a nicer calling convention now.
next prev parent reply other threads:[~2021-01-04 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-30 0:32 [PATCH 0/6] block: improvement on bioset & bvec allocation Ming Lei
2020-12-30 0:32 ` [PATCH 1/6] block: manage bio slab cache by xarray Ming Lei
2021-01-04 8:54 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 2/6] block: don't pass BIOSET_NEED_BVECS for q->bio_split Ming Lei
2021-01-04 18:13 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 3/6] block: don't allocate inline bvecs if this bioset needn't bvecs Ming Lei
2021-01-04 8:55 ` Christoph Hellwig [this message]
2020-12-30 0:32 ` [PATCH 4/6] block: set .bi_max_vecs as actual allocated vector number Ming Lei
2021-01-04 8:55 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 5/6] block: move three bvec helpers declaration into private helper Ming Lei
2021-01-04 8:56 ` Christoph Hellwig
2020-12-30 0:32 ` [PATCH 6/6] bcache: don't pass BIOSET_NEED_BVECS for the 'bio_set' embedded in 'cache_set' Ming Lei
2021-01-04 8:57 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210104085535.GB28949@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.