Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio

From: Halil Pasic <pasic@linux.ibm.com>
To: "Alex Bennée" <alex.bennee@linaro.org>
Cc: thuth@redhat.com, "Cornelia Huck" <cohuck@redhat.com>,
	qemu-devel@nongnu.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Christian Borntraeger" <borntraeger@de.ibm.com>,
	"open list:S390 Virtio-ccw" <qemu-s390x@nongnu.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH] tests/acceptance: bound the size of readline in s390_ccw_virtio
Date: Tue, 5 Jan 2021 16:06:43 +0100	[thread overview]
Message-ID: <20210105160643.395bef35.pasic@linux.ibm.com> (raw)
In-Reply-To: <20210105124405.15424-1-alex.bennee@linaro.org>

On Tue,  5 Jan 2021 12:44:05 +0000
Alex Bennée <alex.bennee@linaro.org> wrote:

> The read binary data as text via a PPM export of the frame buffer
> seems a bit sketchy and it did blow up in the real world when the
> assertion failed:
> 
>   https://gitlab.com/qemu-project/qemu/-/jobs/943183183
> 
> However short of cleaning up the test to be more binary focused at
> least limit the attempt to dump the whole file as hexified zeros in
> the logs.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Acked-by: Halil Pasic <pasic@linux.ibm.com>

Thanks!

> ---
>  tests/acceptance/machine_s390_ccw_virtio.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/acceptance/machine_s390_ccw_virtio.py b/tests/acceptance/machine_s390_ccw_virtio.py
> index 0f81af9950..5141d6abb2 100644
> --- a/tests/acceptance/machine_s390_ccw_virtio.py
> +++ b/tests/acceptance/machine_s390_ccw_virtio.py
> @@ -241,7 +241,7 @@ class S390CCWVirtioMachine(Test):
>              self.assertEqual(line, b"1024 768\n")
>              line = ppmfile.readline()
>              self.assertEqual(line, b"255\n")
> -            line = ppmfile.readline()
> +            line = ppmfile.readline(size=256)
>              self.assertEqual(line, b"The quick fox jumps over a lazy dog\n")
>  
>          # Hot-plug a virtio-crypto device and see whether it gets accepted