Re: [PATCH v4] power/supply: Add ltc4162-l-charger

From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] power/supply: Add ltc4162-l-charger
Date: Wed, 6 Jan 2021 16:16:44 +0100	[thread overview]
Message-ID: <20210106151644.jyfpjvazof565mhk@earth.universe> (raw)
In-Reply-To: <20210106075557.21626-1-mike.looijmans@topic.nl>

[-- Attachment #1: Type: text/plain, Size: 1313 bytes --]

Hi,

On Wed, Jan 06, 2021 at 08:55:57AM +0100, Mike Looijmans wrote:
> Add support for the LTC4162-L Li-Ion battery charger. The driver allows
> reading back telemetry and to set some charging options like the input
> current limit.
> 
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> v2: Use microohm units instead of milliohm
>     Add interrupt support using smbalert
>     Support obtaining cell-count from devicetree
> v3: Fix overflows in calculations involving resistor values
> v4: Use attr_grp member to register attributes
>     Report input current/voltage for charger and make battery
>     voltage and current into sysfs attributes

Fine with me until we have a better way to solve the problem. IIUIC
you no longer have access to the hardware anyways? But you need to
document the custom sysfs nodes: Please document them in the
following file:

Documentation/ABI/testing/sysfs-class-power-ltc4162l

[...]

> +static int ltc4162l_remove(struct i2c_client *client)
> +{
> +	struct ltc4162l_info *info = i2c_get_clientdata(client);
> +
> +	sysfs_remove_group(&info->charger->dev.kobj, &ltc4162l_attr_group);
> +
> +	return 0;
> +}

power-supply core automatically removes the sysfs groups specified
in power_supply_config.attr_grp.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]