From: Josh Poimboeuf <jpoimboe@redhat.com>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Kees Cook <keescook@chromium.org>,
linux-hardening@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins...
Date: Mon, 11 Jan 2021 07:37:19 -0600 [thread overview]
Message-ID: <20210111133719.w53ad4xnw5yyi2lf@treble> (raw)
In-Reply-To: <128149.1610368277@turing-police>
On Mon, Jan 11, 2021 at 07:31:17AM -0500, Valdis Klētnieks wrote:
> On Mon, 11 Jan 2021 05:56:59 -0500, I said:
>
> > > It's probably related. I'm just having a hard time understanding why 4.9 and 5.4
> > > whine about the lack of a space, while 8.3 and 11 didn't complain...
>
> So after more digging, at least some clarity has surfaced.
>
> It looks like it's not a kernel source tree issue, it's a g++ issue fixed in g++ 6 and later.
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69959
>
> And it looks like there was an intent to backport it to 4.9 and 5.4:
> https://gcc.gnu.org/legacy-ml/gcc-patches/2016-02/msg01409.html
>
> The bugtracker doesn't show an equivalent for 69959 being closed against 4.9.x or 5.[56],
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63254 has a patch for one of the
> gcc-supplied files that tosses the warning, but that way lies madness...
>
> Not sure what we want to do here - the main alternatives I see are:
>
> Tell people still using 4.9/5.4 to either live with the warning or upgrade to 6 or later
>
> Make the flag a variable and pass either -std=gnu++98 or -std=gnu++11
> depending on the output of 'g++ --version'
>
> What say the peanut gallery?
I think putting the flag in a variable (based on call cc-ifversion)
should be easy enough, then we can put this little saga behind us and
pretend it never happened :-)
--
Josh
next prev parent reply other threads:[~2021-01-11 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-26 18:21 [PATCH] gcc-plugins: fix gcc 11 indigestion with plugins Valdis Klētnieks
2021-01-05 15:26 ` Josh Poimboeuf
2021-01-06 23:09 ` Kees Cook
2021-01-11 9:47 ` Geert Uytterhoeven
2021-01-11 10:56 ` Valdis Klētnieks
2021-01-11 11:02 ` Geert Uytterhoeven
2021-01-11 12:31 ` Valdis Klētnieks
2021-01-11 13:37 ` Josh Poimboeuf [this message]
2021-01-11 19:48 ` Kees Cook
2021-01-11 19:55 ` Valdis Klētnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210111133719.w53ad4xnw5yyi2lf@treble \
--to=jpoimboe@redhat.com \
--cc=geert@linux-m68k.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valdis.kletnieks@vt.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.