From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Sangwon Jee <jeesw@melfas.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org
Subject: [PATCH 2/5] input: touchscreen: melfas_mip4: Mark a bunch of variables as __always_unused
Date: Thu, 14 Jan 2021 15:23:20 +0000 [thread overview]
Message-ID: <20210114152323.2382283-3-lee.jones@linaro.org> (raw)
In-Reply-To: <20210114152323.2382283-1-lee.jones@linaro.org>
Dmitry requested to keep these around for the purposes of documentation.
Fixes the following W=1 kernel build warning(s):
drivers/input/touchscreen/melfas_mip4.c: In function ‘mip4_report_touch’:
drivers/input/touchscreen/melfas_mip4.c:474:5: warning: variable ‘size’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:472:5: warning: variable ‘pressure_stage’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:469:7: warning: variable ‘palm’ set but not used [-Wunused-but-set-variable]
drivers/input/touchscreen/melfas_mip4.c:468:7: warning: variable ‘hover’ set but not used [-Wunused-but-set-variable]
Cc: Sangwon Jee <jeesw@melfas.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: linux-input@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/input/touchscreen/melfas_mip4.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/input/touchscreen/melfas_mip4.c b/drivers/input/touchscreen/melfas_mip4.c
index c0050044a5a9e..225796a3f5460 100644
--- a/drivers/input/touchscreen/melfas_mip4.c
+++ b/drivers/input/touchscreen/melfas_mip4.c
@@ -465,13 +465,13 @@ static void mip4_report_keys(struct mip4_ts *ts, u8 *packet)
static void mip4_report_touch(struct mip4_ts *ts, u8 *packet)
{
int id;
- bool hover;
- bool palm;
+ bool __always_unused hover;
+ bool __always_unused palm;
bool state;
u16 x, y;
- u8 pressure_stage = 0;
+ u8 __always_unused pressure_stage = 0;
u8 pressure;
- u8 size;
+ u8 __always_unused size;
u8 touch_major;
u8 touch_minor;
--
2.25.1
next prev parent reply other threads:[~2021-01-14 15:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 15:23 [PATCH v3 0/5] (Set 2/2) Rid W=1 issues from Input Lee Jones
2021-01-14 15:23 ` Lee Jones
2021-01-14 15:23 ` [PATCH 1/5] input: mouse: synaptics: Replace NOOP with suitable commentary Lee Jones
2021-01-14 15:23 ` Lee Jones [this message]
2021-01-20 2:18 ` [PATCH 2/5] input: touchscreen: melfas_mip4: Mark a bunch of variables as __always_unused Dmitry Torokhov
2021-01-14 15:23 ` [PATCH 3/5] input: touchscreen: usbtouchscreen: Actually check return value of usb_submit_urb() Lee Jones
2021-01-20 2:21 ` Dmitry Torokhov
2021-01-14 15:23 ` [PATCH 4/5] input: touchscreen: surface3_spi: Remove set but unused variable 'timestamp' Lee Jones
2021-01-14 16:04 ` Benjamin Tissoires
2021-01-20 2:23 ` Dmitry Torokhov
2021-01-14 15:23 ` [PATCH 5/5] input: touchscreen: stmpe-ts: Add description for 'prop' struct member Lee Jones
2021-01-14 15:23 ` Lee Jones
2021-01-20 2:23 ` Dmitry Torokhov
2021-01-20 2:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210114152323.2382283-3-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jeesw@melfas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.