Re: [RFC PATCH v3 2/8] Add a reference to ucounts for each cred

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH v3 2/8] Add a reference to ucounts for each cred
Date: Sat, 16 Jan 2021 10:29:46 +0800	[thread overview]
Message-ID: <202101161026.Dxs9iwTx-lkp@intel.com> (raw)
In-Reply-To: <bea844285b19c8caf2e656c7ea329a7b2e812c42.1610722474.git.gladkov.alexey@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 3138 bytes --]

Hi Alexey,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on kselftest/next]
[also build test WARNING on linux/master linus/master hnaz-linux-mm/master v5.11-rc3 next-20210115]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Alexey-Gladkov/Count-rlimits-in-each-user-namespace/20210115-230051
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
config: arm64-randconfig-r023-20210115 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project 5b42fd8dd4e7e29125a09a41a33af7c9cb57d144)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install arm64 cross compiling tool for clang build
        # apt-get install binutils-aarch64-linux-gnu
        # https://github.com/0day-ci/linux/commit/14c3c8a27f70d6d6b7c1d64a9af899eb80169495
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alexey-Gladkov/Count-rlimits-in-each-user-namespace/20210115-230051
        git checkout 14c3c8a27f70d6d6b7c1d64a9af899eb80169495
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=arm64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> kernel/cred.c:149:20: warning: if statement has empty body [-Wempty-body]
           if (cred->ucounts);
                             ^
   kernel/cred.c:149:20: note: put the semicolon on a separate line to silence this warning
   1 warning generated.

vim +149 kernel/cred.c

   127	
   128	/**
   129	 * __put_cred - Destroy a set of credentials
   130	 * @cred: The record to release
   131	 *
   132	 * Destroy a set of credentials on which no references remain.
   133	 */
   134	void __put_cred(struct cred *cred)
   135	{
   136		kdebug("__put_cred(%p{%d,%d})", cred,
   137		       atomic_read(&cred->usage),
   138		       read_cred_subscribers(cred));
   139	
   140		BUG_ON(atomic_read(&cred->usage) != 0);
   141	#ifdef CONFIG_DEBUG_CREDENTIALS
   142		BUG_ON(read_cred_subscribers(cred) != 0);
   143		cred->magic = CRED_MAGIC_DEAD;
   144		cred->put_addr = __builtin_return_address(0);
   145	#endif
   146		BUG_ON(cred == current->cred);
   147		BUG_ON(cred == current->real_cred);
   148	
 > 149		if (cred->ucounts);
   150			BUG_ON(cred->ucounts->ns != cred->user_ns);
   151	
   152		if (cred->non_rcu)
   153			put_cred_rcu(&cred->rcu);
   154		else
   155			call_rcu(&cred->rcu, put_cred_rcu);
   156	}
   157	EXPORT_SYMBOL(__put_cred);
   158	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38947 bytes --]