From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Benson Leung <bleung@google.com>
Cc: Daisuke Nojiri <dnojiri@chromium.org>,
vpalatin@chromium.org, Lee Jones <lee.jones@linaro.org>,
Benson Leung <bleung@chromium.org>,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Guenter Roeck <groeck@chromium.org>,
Prashant Malani <pmalani@chromium.org>,
Mark Brown <broonie@kernel.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Alex Levin <levinale@google.com>,
Gwendal Grignou <gwendal@chromium.org>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Vijay Hiremath <vijay.p.hiremath@intel.com>,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 1/2] power: supply: PCHG: Peripheral device charger
Date: Sat, 16 Jan 2021 14:05:16 +0100 [thread overview]
Message-ID: <20210116130516.j3fumvkajdzh2bdq@earth.universe> (raw)
In-Reply-To: <YACLQBf4KA4uJ6rW@google.com>
[-- Attachment #1: Type: text/plain, Size: 1165 bytes --]
Hi Benson,
On Thu, Jan 14, 2021 at 10:19:44AM -0800, Benson Leung wrote:
> On Wed, Dec 16, 2020 at 08:34:15AM -0800, Daisuke Nojiri wrote:
> > This patch adds a driver for PCHG (Peripheral CHarGer). PCHG is a
> > framework managing power supplies for peripheral devices.
> >
> > This driver creates a sysfs node for each peripheral charge port:
> >
> > /sys/class/power_supply/PCHGn
> >
> > where <n> is the index of a charge port.
> >
> > For example, when a stylus is connected to a NFC/WLC port, the node
> > prints:
> >
> > /sys/class/power_supply/PCHG0/
> > capacity=50
> > status=Charging
> > type=Wireless
> >
> > Signed-off-by: Daisuke Nojiri <dnojiri@chromium.org>
>
> This change seems reasonable to me. I've reviewed the cros_ec_commands header,
> and it looks good.
>
> Sebastian, do you have any comments on this? I can merge this through the
> chrome/platform tree if we have your Acked-By.
There is an unresolved feedback from Guenter Roeck. I wanted to
provide a link to lore, but it looks like it did not made it
through. I guess that's why there was no further reply to his
mail.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-01-16 17:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-16 16:34 [PATCH v2 1/2] power: supply: PCHG: Peripheral device charger Daisuke Nojiri
2020-12-16 16:34 ` [PATCH v2 2/2] mfd: cros_ec: Add peripheral " Daisuke Nojiri
2021-01-14 18:19 ` [PATCH v2 1/2] power: supply: PCHG: Peripheral " Benson Leung
2021-01-16 13:05 ` Sebastian Reichel [this message]
[not found] ` <20201216182330.GA63657@roeck-us.net>
2021-01-16 13:23 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210116130516.j3fumvkajdzh2bdq@earth.universe \
--to=sebastian.reichel@collabora.com \
--cc=bleung@chromium.org \
--cc=bleung@google.com \
--cc=broonie@kernel.org \
--cc=dnojiri@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gustavoars@kernel.org \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=levinale@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pihsun@chromium.org \
--cc=pmalani@chromium.org \
--cc=vijay.p.hiremath@intel.com \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.