From: Minwoo Im <minwoo.im.dev@gmail.com>
To: Klaus Jensen <its@irrelevant.dk>
Cc: Fam Zheng <fam@euphon.net>, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2 02/12] hw/block/nvme: fix 64 bit register hi/lo split writes
Date: Tue, 19 Jan 2021 11:09:31 +0900 [thread overview]
Message-ID: <20210119020931.GA5939@localhost.localdomain> (raw)
In-Reply-To: <YAXnNAo/Cva7gTQx@apples.localdomain>
On 21-01-18 20:53:24, Klaus Jensen wrote:
> On Jan 18 21:59, Minwoo Im wrote:
> > > The spec requires aligned 32 bit accesses (or the size of the register),
> > > so maybe it's about time we actually ignore instead of falling through.
> >
> > Agreed.
> >
>
> On the other hand.
>
> The spec just allows undefined behavior if the alignment or size
> requirement is violated. So falling through is not wrong.
If so, maybe we just can make this MMIO region support under 4bytes
access with error messaging. I don't think we should not support them
on purpose because spec says it just results in undefined behaviors
which is just undefined how to handle them.
next prev parent reply other threads:[~2021-01-19 2:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 9:46 [PATCH v2 00/12] hw/block/nvme: misc cmb/pmr patches and bump to v1.4 Klaus Jensen
2021-01-18 9:46 ` [PATCH v2 01/12] hw/block/nvme: add size to mmio read/write trace events Klaus Jensen
2021-01-18 12:29 ` Minwoo Im
2021-01-18 9:46 ` [PATCH v2 02/12] hw/block/nvme: fix 64 bit register hi/lo split writes Klaus Jensen
2021-01-18 12:41 ` Minwoo Im
2021-01-18 12:53 ` Klaus Jensen
2021-01-18 12:59 ` Minwoo Im
2021-01-18 19:53 ` Klaus Jensen
2021-01-19 2:09 ` Minwoo Im [this message]
2021-01-19 18:58 ` Keith Busch
2021-01-18 9:46 ` [PATCH v2 03/12] hw/block/nvme: indicate CMB support through controller capabilities register Klaus Jensen
2021-01-18 12:42 ` Minwoo Im
2021-01-18 9:46 ` [PATCH v2 04/12] hw/block/nvme: move msix table and pba to BAR 0 Klaus Jensen
2021-01-18 12:48 ` Minwoo Im
2021-01-18 9:46 ` [PATCH v2 05/12] hw/block/nvme: allow cmb and pmr to coexist Klaus Jensen
2021-01-18 12:50 ` Minwoo Im
2021-01-18 9:46 ` [PATCH v2 06/12] hw/block/nvme: rename PMR/CMB shift/mask fields Klaus Jensen
2021-01-18 12:52 ` Minwoo Im
2021-01-18 9:47 ` [PATCH v2 07/12] hw/block/nvme: remove redundant zeroing of PMR registers Klaus Jensen
2021-01-18 12:55 ` Minwoo Im
2021-01-18 13:02 ` Klaus Jensen
2021-01-18 9:47 ` [PATCH v2 08/12] hw/block/nvme: disable PMR at boot up Klaus Jensen
2021-01-18 9:47 ` [PATCH v2 09/12] hw/block/nvme: add PMR RDS/WDS support Klaus Jensen
2021-01-18 9:47 ` [PATCH v2 10/12] hw/block/nvme: move cmb logic to v1.4 Klaus Jensen
2021-01-18 12:58 ` Minwoo Im
2021-01-18 13:04 ` Klaus Jensen
2021-01-18 13:09 ` Minwoo Im
2021-01-18 13:10 ` Klaus Jensen
2021-01-18 13:12 ` Minwoo Im
2021-01-18 13:22 ` Klaus Jensen
2021-01-18 19:23 ` Klaus Jensen
2021-01-19 2:11 ` Minwoo Im
2021-01-18 9:47 ` [PATCH v2 11/12] hw/block/nvme: bump " Klaus Jensen
2021-01-18 9:47 ` [PATCH v2 12/12] hw/block/nvme: lift cmb restrictions Klaus Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119020931.GA5939@localhost.localdomain \
--to=minwoo.im.dev@gmail.com \
--cc=fam@euphon.net \
--cc=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.