All of lore.kernel.org
 help / color / mirror / Atom feed
From: "HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>
To: Aili Yao <yaoaili@kingsoft.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
	"osalvador@suse.de" <osalvador@suse.de>,
	"YANGFENG1@kingsoft.com" <YANGFENG1@kingsoft.com>
Subject: Re: [PATCH v4] mm,hwpoison: Differentiate Action Required error in current and non  current processes
Date: Wed, 20 Jan 2021 07:59:23 +0000	[thread overview]
Message-ID: <20210120075923.GA30851@hori.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <20210120150302.2bd277e3.yaoaili@kingsoft.com>

It's desirable that $SUBJECT represents what that patch does, so
how about something like
"mm, hwpoison: send SIGBUS to PF_MCE_EARLY processes on action required events" ?

On Wed, Jan 20, 2021 at 03:03:02PM +0800, Aili Yao wrote:
> When a memory uncorrected error is triggered by process A who accessed
> the address with error; It's Action Required Case for only current
> process which triggered this.this Action Required case means Action
> optional to other process who share the same page. Usually, kill current
> process will be sufficient, other process sharing the same page will
> get be signaled when they really touch the poisoned page.
> 
> But there is another scenario that other processes
> sharing the same page want to be signaled early with PF_MCE_EARLY set,
> In this case, we should get them into kill list and signal
> BUS_MCEERR_AO to them.
> 
> So in this patch, task_early_kill will check current process if
> force_early is set, and if not current,check find_early_kill_thread
> to see if there is PF_MCE_EARLY process which cares the error.
> 
> In kill_proc, BUS_MCEERR_AR is only send to current, other process in
> kill list will be signaled BUS_MCEERR_AO.
> 
> Signed-off-by: Aili Yao <yaoaili@kingsoft.com>
...
> @@ -440,10 +443,13 @@ static struct task_struct *find_early_kill_thread(struct task_struct *tsk)
>   * Determine whether a given process is "early kill" process which expects
>   * to be signaled when some page under the process is hwpoisoned.
>   * Return task_struct of the dedicated thread (main thread unless explicitly
> - * specified) if the process is "early kill," and otherwise returns NULL.
> + * specified) if the process is "early kill" and otherwise returns NULL.
>   *
> - * Note that the above is true for Action Optional case, but not for Action
> - * Required case where SIGBUS should sent only to the current thread.
> + * Note that the above is true for Action Optional case. For Action Required
> + * case, it's only meaningful to the current thread which need to be signaled
> + * with SIGBUS, this error is Action Optional for other non current
> + * processes sharing the same error page,if the process is "early kill",the

Please insert a whitespace after commas (just for convention).

With these fixed, I agree with this patch.

Acked-by: Naoya Horiguchi <naoya.horiguchi@nec.com>

  reply	other threads:[~2021-01-20  7:59 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20  7:03 [PATCH v4] mm,hwpoison: Differentiate Action Required error in current and non current processes Aili Yao
2021-01-20  7:59 ` HORIGUCHI NAOYA(堀口 直也) [this message]
2021-01-20  8:27   ` Aili Yao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210120075923.GA30851@hori.linux.bs1.fc.nec.co.jp \
    --to=naoya.horiguchi@nec.com \
    --cc=YANGFENG1@kingsoft.com \
    --cc=linux-mm@kvack.org \
    --cc=osalvador@suse.de \
    --cc=yaoaili@kingsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.