From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Subject: [PATCH v2 0/2] gmsl: Use unsigned constants and BIT where appropriate
Date: Wed, 20 Jan 2021 15:46:12 +0000 [thread overview]
Message-ID: <20210120154614.2750268-1-kieran.bingham+renesas@ideasonboard.com> (raw)
During pre-integration reviews of the GMSL (MAX9286/MAX9271) patches,
one comment was to mark the constants used in bitfield shifts as
explicitly unsigned. This ensures that any use of a register write that
updates bit 31 is operated correctly.
Whilst none of these register shifts affect bit 31 in any of the
registers, update the values to follow best practices and ensure
consistency if further additions are made.
Please note, this does not remove or clean up the 'Prefer BIT' check
patch warnings, as the use of the BIT macro is still not applicable to
all of these entries. Entries where it is applicable and only a single
bit is modified have been converted accordingly.
Kieran Bingham (2):
media: i2c: max9286: Use unsigned constants and BIT()
media: i2c: max9271: Use unsigned constants
drivers/media/i2c/max9271.h | 60 +++++++++++------------
drivers/media/i2c/max9286.c | 96 ++++++++++++++++++-------------------
2 files changed, 78 insertions(+), 78 deletions(-)
--
2.25.1
next reply other threads:[~2021-01-20 15:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-20 15:46 Kieran Bingham [this message]
2021-01-20 15:46 ` [PATCH v2 1/2] media: i2c: max9286: Use unsigned constants and BIT() Kieran Bingham
2021-03-23 7:51 ` Mauro Carvalho Chehab
2021-01-20 15:46 ` [PATCH v2 2/2] media: i2c: max9271: Use unsigned constants Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120154614.2750268-1-kieran.bingham+renesas@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.