From: Manuel Bouyer <bouyer@antioche.eu.org>
To: Ian Jackson <iwj@xenproject.org>
Cc: "Roger Pau Monné" <roger.pau@citrix.com>, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD
Date: Wed, 20 Jan 2021 17:59:23 +0100 [thread overview]
Message-ID: <20210120165923.GC5035@antioche.eu.org> (raw)
In-Reply-To: <24584.22125.355284.48139@mariner.uk.xensource.com>
On Wed, Jan 20, 2021 at 04:12:29PM +0000, Ian Jackson wrote:
> Manuel Bouyer writes ("Re: [PATCH 05/24] Introduce locking functions for block device setup on NetBSD"):
> > Yes, at last the stat call will need to be patched.
> > But it seems to rely on a linux-specific behavoir, which is that
> > /dev/stdin points to the real file on redirection:
> > >ls -l /dev/stdin /proc/self/fd/0 < /etc/passwd
> > lrwxrwxrwx 1 root root 15 Apr 30 2019 /dev/stdin -> /proc/self/fd/0
> > lr-x------ 1 bouyer ita-iatos 64 Jan 20 16:54 /proc/self/fd/0 -> /etc/passwd
> >
> > On NetBSD (and I guess other BSDs) this won't work, as /dev/stdin is a
> > specific device:
> > >ls -l /dev/stdin
> > crw-rw-rw- 1 root wheel 22, 0 Nov 15 2007 /dev/stdin
> >
> > so stat -L will always return the same data. We can't use the same
> > protocol.
>
> Ah.
>
> The manpage I am looking at says:
>
> If no argument is given, stat displays information about the
> file descriptor for standard input.
>
> Here NetBSD has a better command line API than Linux - Linux requires
> pratting about with /dev/stdin and NetBSD doesn't. So I think
> where on Linux we have
> stat .... /dev/stdin
> on NetBsd we can simply have
> stat ....
> with no filename argument.
Right, thanks. Then it would need to be done with 2 different calls
but I don't think that's a problem (even with the linux version it would
not be atomic anyway).
>
> I think NetBSD's stat(1) also takes different argumnts to specify the
> format. NetBSD uses -f, whereas Linux uses -c. So the exact rune
> will have to be different.
Yes, and NetBSD doens't have %D (only %d)
--
Manuel Bouyer <bouyer@antioche.eu.org>
NetBSD: 26 ans d'experience feront toujours la difference
--
next prev parent reply other threads:[~2021-01-20 16:59 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-14 16:35 [PATCH 00/24] NetBSD fixes Manuel Bouyer
2020-12-14 16:36 ` [PATCH 01/24] Fix lock directory path for NetBSD Manuel Bouyer
2020-12-14 16:36 ` [PATCH 02/24] NetBSD doens't need xenbackendd with xl toolstack Manuel Bouyer
2020-12-29 11:17 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 03/24] Fix lock directory path for NetBSD Manuel Bouyer
2020-12-14 16:36 ` [PATCH 04/24] Make xg_main.c build on NetBSD Manuel Bouyer
2020-12-29 11:24 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 05/24] Introduce locking functions for block device setup " Manuel Bouyer
2020-12-29 11:29 ` Roger Pau Monné
2021-01-04 10:20 ` Manuel Bouyer
2021-01-20 15:13 ` Ian Jackson
2021-01-20 15:59 ` Manuel Bouyer
2021-01-20 16:12 ` Ian Jackson
2021-01-20 16:59 ` Manuel Bouyer [this message]
2021-01-20 17:03 ` Ian Jackson
2021-01-20 17:19 ` Ian Jackson
2020-12-14 16:36 ` [PATCH 06/24] Handle the case where vifname is not present in xenstore Manuel Bouyer
2020-12-29 11:43 ` Roger Pau Monné
2021-01-04 10:22 ` Manuel Bouyer
2020-12-14 16:36 ` [PATCH 07/24] Remove NetBSD's system headers. We'll use the system-provided ones, which are up to date Manuel Bouyer
2020-12-29 11:46 ` Roger Pau Monné
2021-01-04 10:25 ` Manuel Bouyer
2021-01-04 17:09 ` Roger Pau Monné
2021-01-04 17:20 ` Manuel Bouyer
2020-12-14 16:36 ` [PATCH 08/24] Make libs/call build on NetBSD Manuel Bouyer
2020-12-29 11:49 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 09/24] Use xen/xenio.h " Manuel Bouyer
2020-12-14 16:36 ` [PATCH 10/24] Make libs/evtchn build " Manuel Bouyer
2020-12-29 11:52 ` Roger Pau Monné
2021-01-04 10:26 ` Manuel Bouyer
2021-01-04 17:15 ` Roger Pau Monné
2021-01-10 12:22 ` Manuel Bouyer
2021-01-11 17:22 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 11/24] Implement foreignmemory " Manuel Bouyer
2020-12-29 12:46 ` Roger Pau Monné
2021-01-04 11:30 ` Manuel Bouyer
2021-01-04 18:24 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 12/24] Implement gnttab " Manuel Bouyer
2020-12-29 11:16 ` Roger Pau Monné
2021-01-04 10:29 ` Manuel Bouyer
2021-01-04 17:24 ` Roger Pau Monné
2021-01-10 12:40 ` Manuel Bouyer
2021-01-11 17:04 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 13/24] Don't assume tv_sec is a unsigned long (for NetBSD) Manuel Bouyer
2020-12-29 14:02 ` Roger Pau Monné
2021-01-04 10:31 ` Manuel Bouyer
2021-01-04 18:17 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 14/24] Pass bridge name to qemu and set XEN_DOMAIN_ID Manuel Bouyer
2020-12-15 8:44 ` Manuel Bouyer
2020-12-29 15:19 ` Roger Pau Monné
2021-01-04 10:36 ` Manuel Bouyer
2020-12-14 16:36 ` [PATCH 15/24] Make libs/light build on NetBSD Manuel Bouyer
2020-12-29 14:15 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 16/24] Switch NetBSD to QEMU_XEN (!traditional) Manuel Bouyer
2020-12-29 14:19 ` Roger Pau Monné
2021-01-04 10:47 ` Manuel Bouyer
2020-12-14 16:36 ` [PATCH 17/24] Make libs/light build on NetBSD Manuel Bouyer
2020-12-29 14:28 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 18/24] xeneventchn_stubs.c doens't need xen/sys/evtchn.h (NetBSD fix) Manuel Bouyer
2020-12-29 14:30 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 19/24] errno may not be a gobal R/W variable, use a local variable instead (fix build on NetBSD) Manuel Bouyer
2020-12-29 14:38 ` Roger Pau Monné
2021-01-04 10:56 ` Manuel Bouyer
2021-01-04 13:30 ` Manuel Bouyer
2020-12-14 16:36 ` [PATCH 20/24] If FILENAME_MAX is defined, use it instead of arbitrary value (fix format-truncation errors with GCC >= 7) Manuel Bouyer
2020-12-29 14:51 ` Roger Pau Monné
2021-01-04 11:03 ` Manuel Bouyer
2020-12-14 16:36 ` [PATCH 21/24] Fix unused functions/variables error Manuel Bouyer
2020-12-14 16:36 ` [PATCH 22/24] If PTHREAD_STACK_MIN is not defined, use DEFAULT_THREAD_STACKSIZE Manuel Bouyer
2020-12-29 14:57 ` Roger Pau Monné
2020-12-14 16:36 ` [PATCH 23/24] Use xen/xenio.h on NetBSD Manuel Bouyer
2020-12-14 16:36 ` [PATCH 24/24] Fix error: array subscript has type 'char' [-Werror=char-subscripts] Manuel Bouyer
2020-12-29 15:23 ` [PATCH 00/24] NetBSD fixes Roger Pau Monné
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210120165923.GC5035@antioche.eu.org \
--to=bouyer@antioche.eu.org \
--cc=iwj@xenproject.org \
--cc=roger.pau@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.