All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudio Imbrenda <imbrenda@linux.ibm.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, david@redhat.com, thuth@redhat.com,
	frankja@linux.ibm.com, cohuck@redhat.com, lvivier@redhat.com,
	nadav.amit@gmail.com, krish.sadhukhan@oracle.com,
	dmatlack@google.com, seanjc@google.com
Subject: [kvm-unit-tests PATCH v1 0/2] Fix smap and pku tests for new allocator
Date: Thu, 21 Jan 2021 12:18:06 +0100	[thread overview]
Message-ID: <20210121111808.619347-1-imbrenda@linux.ibm.com> (raw)

The recent fixes to the page allocator broke the SMAP test.

The reason is that the test blindly took a chunk of memory and used it,
hoping that the page allocator would not touch it.

Unfortunately the memory area affected is exactly where the new
allocator puts the metadata information for the 16M-4G memory area.

This causes the SMAP test to fail.

The solution is to reserve the memory properly using the reserve_pages
function. To make things simpler, the memory area reserved is now
8M-16M instead of 16M-32M.

This issue was not found immediately, because the SMAP test needs
non-default qemu parameters in order not to be skipped.

I tested the patch and it seems to work.

While fixing the SMAP test, I also noticed that the PKU test was doing
the same thing, so I went ahead and fixed that test too in the same
way. Unfortunately I do not have the right hardware and therefore I
cannot test it.



I would really appreciate if someone who has the right hardware could
test the PKU test and see if it works.




Claudio Imbrenda (2):
  x86: smap: fix the test to work with new allocator
  x86: pku: fix the test to work with new allocator

 x86/pku.c  | 5 ++++-
 x86/smap.c | 9 ++++++---
 2 files changed, 10 insertions(+), 4 deletions(-)

-- 
2.26.2


             reply	other threads:[~2021-01-21 11:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-21 11:18 Claudio Imbrenda [this message]
2021-01-21 11:18 ` [kvm-unit-tests PATCH v1 1/2] x86: smap: fix the test to work with new allocator Claudio Imbrenda
2021-01-21 11:18 ` [kvm-unit-tests PATCH v1 2/2] x86: pku: " Claudio Imbrenda
2021-01-21 18:23 ` [kvm-unit-tests PATCH v1 0/2] Fix smap and pku tests for " David Matlack
2021-01-22  0:55   ` Chenyi Qiang
2021-01-23 18:16 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210121111808.619347-1-imbrenda@linux.ibm.com \
    --to=imbrenda@linux.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=dmatlack@google.com \
    --cc=frankja@linux.ibm.com \
    --cc=krish.sadhukhan@oracle.com \
    --cc=kvm@vger.kernel.org \
    --cc=lvivier@redhat.com \
    --cc=nadav.amit@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.