From: Christoph Hellwig <hch@infradead.org>
To: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
danil.kipnis@cloud.ionos.com, jinpu.wang@cloud.ionos.com
Subject: Re: [PATCH 4/4] block: call blk_additional_{latency,sector} only when io_extra_stats is true
Date: Wed, 27 Jan 2021 17:09:14 +0000 [thread overview]
Message-ID: <20210127170914.GA1732537@infradead.org> (raw)
In-Reply-To: <20210127145930.8826-5-guoqing.jiang@cloud.ionos.com>
On Wed, Jan 27, 2021 at 03:59:30PM +0100, Guoqing Jiang wrote:
> + if (blk_queue_io_extra_stat(req->q))
> + blk_additional_sector(req->part, sgrp, bytes >> SECTOR_SHIFT);
This is completely unreadable due to the long line.
next prev parent reply other threads:[~2021-01-27 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 14:59 [PATCH 0/4] block: add two statistic tables Guoqing Jiang
2021-01-27 14:59 ` [PATCH 1/4] block: add a statistic table for io latency Guoqing Jiang
2021-01-27 17:10 ` Christoph Hellwig
2021-01-28 2:44 ` Guoqing Jiang
2021-01-27 14:59 ` [PATCH 2/4] block: add a statistic table for io sector Guoqing Jiang
2021-01-27 14:59 ` [PATCH 3/4] block: add io_extra_stats node Guoqing Jiang
2021-01-27 14:59 ` [PATCH 4/4] block: call blk_additional_{latency,sector} only when io_extra_stats is true Guoqing Jiang
2021-01-27 17:09 ` Christoph Hellwig [this message]
2021-01-28 2:53 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127170914.GA1732537@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=danil.kipnis@cloud.ionos.com \
--cc=guoqing.jiang@cloud.ionos.com \
--cc=jinpu.wang@cloud.ionos.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.