From: Christoph Hellwig <hch@lst.de>
To: Brian Foster <bfoster@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync
Date: Thu, 28 Jan 2021 09:00:34 +0100 [thread overview]
Message-ID: <20210128080034.GA29023@lst.de> (raw)
In-Reply-To: <20210125131618.GA2047559@bfoster>
On Mon, Jan 25, 2021 at 08:16:18AM -0500, Brian Foster wrote:
> > - error = xfs_fsync_flush_log(ip, datasync, &log_flushed);
> > + /*
> > + * Any inode that has dirty modifications in the log is pinned. The
> > + * racy check here for a pinned inode while not catch modifications
>
> s/while/will/ ?
Yes. Darrick, can you fix this up when applying the patch, or do you
want me to resend?
next prev parent reply other threads:[~2021-01-28 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-22 16:46 avoid taking the iolock in fsync unless actually needed v2 Christoph Hellwig
2021-01-22 16:46 ` [PATCH 1/2] xfs: refactor xfs_file_fsync Christoph Hellwig
2021-01-22 21:08 ` Dave Chinner
2021-01-22 16:46 ` [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync Christoph Hellwig
2021-01-22 21:08 ` Dave Chinner
2021-01-23 6:41 ` Christoph Hellwig
2021-01-26 6:56 ` Christoph Hellwig
2021-01-25 13:16 ` Brian Foster
2021-01-28 8:00 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2021-01-11 16:15 avoid taking the iolock in fsync unless actually needed Christoph Hellwig
2021-01-11 16:15 ` [PATCH 2/2] xfs: reduce ilock acquisitions in xfs_file_fsync Christoph Hellwig
2021-01-12 15:34 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128080034.GA29023@lst.de \
--to=hch@lst.de \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.