From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Bonzini, Paolo" <pbonzini@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [PATCH] spice: delay starting until display are initialized
Date: Thu, 28 Jan 2021 15:42:02 +0100 [thread overview]
Message-ID: <20210128144202.2pqjjn3epspfvlgk@sirius.home.kraxel.org> (raw)
In-Reply-To: <CAJ+F1CJ0Z378KCLGDzLYOfBor7HkHM2YemRj5F-3kTSnVK7ADg@mail.gmail.com>
> > I still think that moving these three lines to the correct place is
> > enough. Maybe even just qemu_spice_display_start() as it keeps track
> > of the state and you can safely call this twice.
>
> It's not enough, since the first time qemu_spice_display_start() is
> called (on vm_start) the display interfaces aren't yet registered. And
> spice server doesn't automatically start the newly added interfaces.
So move the vmstate handler registration call too?
I'd prefer to not add more state variables if we can avoid it ...
take care,
Gerd
next prev parent reply other threads:[~2021-01-28 14:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 11:13 [PATCH] spice: delay starting until display are initialized marcandre.lureau
2021-01-28 11:43 ` Gerd Hoffmann
2021-01-28 11:57 ` Marc-André Lureau
2021-01-28 12:00 ` Marc-André Lureau
2021-01-28 14:26 ` Gerd Hoffmann
2021-01-28 14:35 ` Marc-André Lureau
2021-01-28 14:42 ` Gerd Hoffmann [this message]
2021-01-28 15:05 ` Marc-André Lureau
2021-01-28 16:34 ` Gerd Hoffmann
2021-01-28 19:28 ` Marc-André Lureau
2021-01-29 14:22 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128144202.2pqjjn3epspfvlgk@sirius.home.kraxel.org \
--to=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.