From: Jakub Kicinski <kuba@kernel.org>
To: Christoph Schemmel <christoph.schemmel@gmail.com>
Cc: bjorn@mork.no, avem@davemloft.net, netdev@vger.kernel.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
hans-christoph.schemmel@thalesgroup.com
Subject: Re: [PATCH] NET: usb: qmi_wwan: Adding support for Cinterion MV31
Date: Mon, 1 Feb 2021 18:43:47 -0800 [thread overview]
Message-ID: <20210201184347.5efe7ec2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210129133001.8240-1-christoph.schemmel@gmail.com>
On Fri, 29 Jan 2021 14:30:01 +0100 Christoph Schemmel wrote:
> Adding support for Cinterion MV31 with PID 0x00B7.
>
> T: Bus=04 Lev=01 Prnt=01 Port=00 Cnt=01 Dev#= 11 Spd=5000 MxCh= 0
> D: Ver= 3.20 Cls=ef(misc ) Sub=02 Prot=01 MxPS= 9 #Cfgs= 1
> P: Vendor=1e2d ProdID=00b7 Rev=04.14
> S: Manufacturer=Cinterion
> S: Product=Cinterion PID 0x00B3 USB Mobile Broadband
> S: SerialNumber=b3246eed
> C: #Ifs= 4 Cfg#= 1 Atr=a0 MxPwr=896mA
> I: If#=0x0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=qmi_wwan
> I: If#=0x1 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x2 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=00 Prot=00 Driver=option
> I: If#=0x3 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=30 Driver=option
>
> Signed-off-by: Christoph Schemmel <christoph.schemmel@gmail.com>
Thanks for the patch, could you repost? We had some issues with the
mailing list and this patch did not get into patchwork.
> diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
> index cc4819282820..b1784db6b098 100644
> --- a/drivers/net/usb/qmi_wwan.c
> +++ b/drivers/net/usb/qmi_wwan.c
> @@ -1309,6 +1309,7 @@ static const struct usb_device_id products[] = {
> {QMI_FIXED_INTF(0x1e2d, 0x0082, 5)}, /* Cinterion PHxx,PXxx (2 RmNet) */
> {QMI_FIXED_INTF(0x1e2d, 0x0083, 4)}, /* Cinterion PHxx,PXxx (1 RmNet + USB Audio)*/
> {QMI_QUIRK_SET_DTR(0x1e2d, 0x00b0, 4)}, /* Cinterion CLS8 */
> + {QMI_FIXED_INTF(0x1e2d, 0x00b7, 0)}, /* Cinterion MV31 RmNet*/
nit: missing space before */
> {QMI_FIXED_INTF(0x413c, 0x81a2, 8)}, /* Dell Wireless 5806 Gobi(TM) 4G LTE Mobile Broadband Card */
> {QMI_FIXED_INTF(0x413c, 0x81a3, 8)}, /* Dell Wireless 5570 HSPA+ (42Mbps) Mobile Broadband Card */
> {QMI_FIXED_INTF(0x413c, 0x81a4, 8)}, /* Dell Wireless 5570e HSPA+ (42Mbps) Mobile Broadband Card */
next parent reply other threads:[~2021-02-02 2:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210129133001.8240-1-christoph.schemmel@gmail.com>
2021-02-02 2:43 ` Jakub Kicinski [this message]
2021-02-02 8:45 [PATCH] NET: usb: qmi_wwan: Adding support for Cinterion MV31 Christoph Schemmel
2021-02-03 23:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210201184347.5efe7ec2@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=avem@davemloft.net \
--cc=bjorn@mork.no \
--cc=christoph.schemmel@gmail.com \
--cc=hans-christoph.schemmel@thalesgroup.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.