From: Christoph Hellwig <hch@lst.de>
To: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Cc: linux-block@vger.kernel.org, paolo.valente@linaro.org,
axboe@kernel.dk, rostedt@goodmis.org, mingo@redhat.com,
johannes.thumshirn@wdc.com, damien.lemoal@wdc.com,
bvanassche@acm.org, dongli.zhang@oracle.com,
akpm@linux-foundation.org, aravind.ramesh@wdc.com,
joshi.k@samsung.com, niklas.cassel@wdc.com, hare@suse.de,
colyli@suse.de, tj@kernel.org, rdunlap@infradead.org,
jack@suse.cz, hch@lst.de
Subject: Re: [PATCH 5/7] block: get rid of the trace rq insert wrapper
Date: Tue, 2 Feb 2021 10:36:02 +0100 [thread overview]
Message-ID: <20210202093602.GE17771@lst.de> (raw)
In-Reply-To: <20210202052544.4108-14-chaitanya.kulkarni@wdc.com>
On Mon, Feb 01, 2021 at 09:25:42PM -0800, Chaitanya Kulkarni wrote:
> Get rid of the wrapper for trace_block_rq_insert() and call the function
> directly.
The placement of the EXPORT_TRACEPOINT_SYMBOL_GPL looks very strange,
I'd keep it with the other EXPORT_TRACEPOINT_SYMBOL_GPL instances in
blk-core.c.
Otherwise this looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-02-02 9:39 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 5:25 [PATCH 0/7] blktrace: few clenaup Chaitanya Kulkarni
2021-02-02 5:25 ` [PATCH 1/7] block: remove superfluous param in blk_fill_rwbs() Chaitanya Kulkarni
2021-02-02 9:02 ` Damien Le Moal
2021-02-02 9:04 ` Damien Le Moal
2021-02-02 9:55 ` Johannes Thumshirn
2021-02-02 5:25 ` [PATCH 2/7] blktrace: add blk_fill_rwbs documentation comment Chaitanya Kulkarni
2021-02-02 9:03 ` Damien Le Moal
2021-02-02 9:55 ` Johannes Thumshirn
2021-02-02 5:25 ` [PATCH 3/7] blktrace: fix blk_rq_issue documentation Chaitanya Kulkarni
2021-02-02 9:04 ` Damien Le Moal
2021-02-02 9:56 ` Johannes Thumshirn
2021-02-02 5:25 ` [PATCH 4/7] blktrace: fix blk_rq_merge documentation Chaitanya Kulkarni
2021-02-02 9:05 ` Damien Le Moal
2021-02-02 9:57 ` Johannes Thumshirn
2021-02-02 5:25 ` [PATCH 5/7] block: get rid of the trace rq insert wrapper Chaitanya Kulkarni
2021-02-02 9:05 ` Damien Le Moal
2021-02-02 9:58 ` Johannes Thumshirn
2021-02-02 5:25 ` [PATCH 6/7] null_blk: allow disacrd on non-membacked mode Chaitanya Kulkarni
2021-02-02 9:08 ` Damien Le Moal
2021-02-02 5:25 ` [PATCH 7/7] null_blk: add module param queue bounce limit Chaitanya Kulkarni
2021-02-02 9:18 ` Damien Le Moal
2021-02-02 5:25 ` [PATCH 0/7] blktrace: few clenaup Chaitanya Kulkarni
2021-02-02 5:25 ` [PATCH 1/7] block: remove superfluous param in blk_fill_rwbs() Chaitanya Kulkarni
2021-02-02 9:34 ` Christoph Hellwig
2021-02-02 5:25 ` [PATCH 2/7] blktrace: add blk_fill_rwbs documentation comment Chaitanya Kulkarni
2021-02-02 9:34 ` Christoph Hellwig
2021-02-02 5:25 ` [PATCH 3/7] blktrace: fix blk_rq_issue documentation Chaitanya Kulkarni
2021-02-02 9:34 ` Christoph Hellwig
2021-02-02 5:25 ` [PATCH 4/7] blktrace: fix blk_rq_merge documentation Chaitanya Kulkarni
2021-02-02 9:34 ` Christoph Hellwig
2021-02-02 5:25 ` [PATCH 5/7] block: get rid of the trace rq insert wrapper Chaitanya Kulkarni
2021-02-02 9:36 ` Christoph Hellwig [this message]
2021-02-02 5:25 ` [PATCH 6/7] null_blk: allow disacrd on non-membacked mode Chaitanya Kulkarni
2021-02-02 9:36 ` Christoph Hellwig
2021-02-02 20:15 ` Chaitanya Kulkarni
2021-02-02 5:25 ` [PATCH 7/7] null_blk: add module param queue bounce limit Chaitanya Kulkarni
2021-02-02 5:29 ` [PATCH 0/7] blktrace: few clenaup Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210202093602.GE17771@lst.de \
--to=hch@lst.de \
--cc=akpm@linux-foundation.org \
--cc=aravind.ramesh@wdc.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=colyli@suse.de \
--cc=damien.lemoal@wdc.com \
--cc=dongli.zhang@oracle.com \
--cc=hare@suse.de \
--cc=jack@suse.cz \
--cc=johannes.thumshirn@wdc.com \
--cc=joshi.k@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=niklas.cassel@wdc.com \
--cc=paolo.valente@linaro.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.