All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: fdmanana@kernel.org
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] btrfs: fix extent buffer leak on failure to copy root
Date: Thu, 4 Feb 2021 17:08:43 +0100	[thread overview]
Message-ID: <20210204160843.GH1993@twin.jikos.cz> (raw)
In-Reply-To: <aa032e11aa2b8667a28a93b90691d6f790711c62.1612449293.git.fdmanana@suse.com>

On Thu, Feb 04, 2021 at 02:35:44PM +0000, fdmanana@kernel.org wrote:
> From: Filipe Manana <fdmanana@suse.com>
> 
> At btrfs_copy_root(), if the call to btrfs_inc_ref() fails we end up
> returning without unlocking and releasing our reference on the extent
> buffer named "cow" we previously allocated with btrfs_alloc_tree_block().
> 
> So fix that by unlocking the extent buffer and dropping our reference on
> it before returning.
> 
> Fixes: be20aa9dbadc8c ("Btrfs: Add mount option to turn off data cow")
> Signed-off-by: Filipe Manana <fdmanana@suse.com>

Added to misc-next, thanks.

      reply	other threads:[~2021-02-04 16:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-04 14:35 [PATCH] btrfs: fix extent buffer leak on failure to copy root fdmanana
2021-02-04 16:08 ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210204160843.GH1993@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=fdmanana@kernel.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.