From: Vinod Koul <vkoul@kernel.org>
To: Jack Pham <jackp@codeaurora.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org, Andy Gross <agross@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm8350: add USB and PHY device nodes
Date: Fri, 5 Feb 2021 10:11:47 +0530 [thread overview]
Message-ID: <20210205044147.GE2656@vkoul-mobl.Dlink> (raw)
In-Reply-To: <20210204180552.GA25531@jackp-linux.qualcomm.com>
Hello Jack,
On 04-02-21, 10:05, Jack Pham wrote:
> On Thu, Feb 04, 2021 at 10:39:03PM +0530, Vinod Koul wrote:
> > From: Jack Pham <jackp@codeaurora.org>
> > +
> > + resets = <&gcc 20>;
>
> Shouldn't this (and all the other gcc phandles below) use the
> dt-bindings macros from here?
> https://patchwork.kernel.org/project/linux-arm-msm/patch/20210118044321.2571775-5-vkoul@kernel.org/
Ideally yes but it would cause build failure on qcom tree and the header
is not available here. I have a patch [1] to convert all numbers to enum
values which would be sent once header is in qcom tree (after next merge
window)..
This way we could get SM8350 booting to shell with basic things on next
rc1 rather than wait for 2 cycles.
Thanks
--
~Vinod
next prev parent reply other threads:[~2021-02-05 4:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 17:09 [PATCH 0/6]: arm64: dts: qcom: sm8350: more device support Vinod Koul
2021-02-04 17:09 ` [PATCH 1/6] arm64: dts: qcom: Add SM8350 apss_smmu node Vinod Koul
2021-02-04 17:09 ` [PATCH 2/6] arm64: dts: qcom: sm8350: add USB and PHY device nodes Vinod Koul
2021-02-04 18:05 ` Jack Pham
2021-02-05 4:41 ` Vinod Koul [this message]
2021-02-04 17:09 ` [PATCH 3/6] arm64: dts: qcom: sm8350-mtp: enable USB nodes Vinod Koul
2021-02-04 17:09 ` [PATCH 4/6] arm64: dts: qcom: Add SM8350 UFS nodes Vinod Koul
2021-02-04 17:09 ` [PATCH 5/6] arm64: dts: qcom: sm8350-mtp: enable " Vinod Koul
2021-02-04 17:09 ` [PATCH 6/6] arm64: dts: qcom: sm8350-mtp: add regulator names Vinod Koul
2021-03-06 0:20 ` [PATCH 0/6]: arm64: dts: qcom: sm8350: more device support patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210205044147.GE2656@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=jackp@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.