All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, eblake@redhat.com, fam@euphon.net,
	stefanha@redhat.com, mreitz@redhat.com, kwolf@redhat.com,
	vsementsov@virtuozzo.com, jsnow@redhat.com, den@openvz.org
Subject: [PATCH v2 04/10] job: add .cancel handler for the driver
Date: Fri,  5 Feb 2021 19:37:14 +0300	[thread overview]
Message-ID: <20210205163720.887197-5-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20210205163720.887197-1-vsementsov@virtuozzo.com>

To be used in mirror in the following commit to cancel in-flight io on
target to not waste the time.

Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
 include/qemu/job.h | 5 +++++
 job.c              | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/include/qemu/job.h b/include/qemu/job.h
index 32aabb1c60..efc6fa7544 100644
--- a/include/qemu/job.h
+++ b/include/qemu/job.h
@@ -251,6 +251,11 @@ struct JobDriver {
      */
     void (*clean)(Job *job);
 
+    /**
+     * If the callback is not NULL, it will be invoked in job_cancel_async
+     */
+    void (*cancel)(Job *job);
+
 
     /** Called when the job is freed */
     void (*free)(Job *job);
diff --git a/job.c b/job.c
index 3aaaebafe2..289edee143 100644
--- a/job.c
+++ b/job.c
@@ -715,6 +715,9 @@ static int job_finalize_single(Job *job)
 
 static void job_cancel_async(Job *job, bool force)
 {
+    if (job->driver->cancel) {
+        job->driver->cancel(job);
+    }
     if (job->user_paused) {
         /* Do not call job_enter here, the caller will handle it.  */
         if (job->driver->user_resume) {
-- 
2.29.2



  parent reply	other threads:[~2021-02-05 16:49 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 16:37 [PATCH v2 00/10] mirror: cancel nbd reconnect Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 01/10] block: add new BlockDriver handler: bdrv_cancel_in_flight Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 02/10] block/nbd: implement .bdrv_cancel_in_flight Vladimir Sementsov-Ogievskiy
2021-02-12 17:14   ` Eric Blake
2021-02-05 16:37 ` [PATCH v2 03/10] block/raw-format: implement .bdrv_cancel_in_flight handler Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` Vladimir Sementsov-Ogievskiy [this message]
2021-02-12 17:21   ` [PATCH v2 04/10] job: add .cancel handler for the driver Eric Blake
2021-02-05 16:37 ` [PATCH v2 05/10] block/mirror: implement .cancel job handler Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 06/10] iotests/264: move to python unittest Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 07/10] iotests.py: qemu_nbd_popen: remove pid file after use Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 08/10] iotests/264: add mirror-cancel test-case Vladimir Sementsov-Ogievskiy
2022-07-21  8:50   ` Thomas Huth
2022-07-21 19:21     ` Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 09/10] block/backup: implement .cancel job handler Vladimir Sementsov-Ogievskiy
2021-02-05 16:37 ` [PATCH v2 10/10] iotests/264: add backup-cancel test-case Vladimir Sementsov-Ogievskiy
2021-02-12 18:21 ` [PATCH v2 00/10] mirror: cancel nbd reconnect Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210205163720.887197-5-vsementsov@virtuozzo.com \
    --to=vsementsov@virtuozzo.com \
    --cc=den@openvz.org \
    --cc=eblake@redhat.com \
    --cc=fam@euphon.net \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.