From: Mike Christie <michael.christie@oracle.com>
To: lduncan@suse.com, cleech@redhat.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com
Cc: lutianxiong@huawei.com, linfeilong@huawei.com,
liuzhiqiang26@huawei.com, haowenchao@huawei.com,
Mike Christie <michael.christie@oracle.com>
Subject: [PATCH 8/9] qla4xxx: use iscsi_is_session_online
Date: Sat, 6 Feb 2021 22:46:07 -0600 [thread overview]
Message-ID: <20210207044608.27585-9-michael.christie@oracle.com> (raw)
In-Reply-To: <20210207044608.27585-1-michael.christie@oracle.com>
__qla4xxx_is_chap_active just wants to know if a session is online and
does not care about why it's not, so this has it use
iscsi_is_session_online.
This is not a bug now, but the next patch changes the behavior of
iscsi_session_chkready so this patch just prepares the driver for that
change.
Signed-off-by: Mike Christie <michael.christie@oracle.com>
Reviewed-by: Lee Duncan <lduncan@suse.com>
---
drivers/scsi/qla4xxx/ql4_os.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
index a4b014e1cd8c..7bd9a4a04ad5 100644
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -841,7 +841,7 @@ static int __qla4xxx_is_chap_active(struct device *dev, void *data)
sess = cls_session->dd_data;
ddb_entry = sess->dd_data;
- if (iscsi_session_chkready(cls_session))
+ if (iscsi_is_session_online(cls_session))
goto exit_is_chap_active;
if (ddb_entry->chap_tbl_idx == *chap_tbl_idx)
--
2.25.1
next prev parent reply other threads:[~2021-02-07 4:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 4:45 [PATCH 0/9 V6] iscsi fixes and cleanups Mike Christie
2021-02-07 4:46 ` [PATCH 1/9] libiscsi: fix iscsi_prep_scsi_cmd_pdu error handling Mike Christie
2021-02-07 4:46 ` [PATCH 2/9] libiscsi: drop taskqueuelock Mike Christie
2021-02-07 4:46 ` [PATCH 3/9] libiscsi: fix iscsi_task use after free Mike Christie
2021-02-07 4:46 ` [PATCH 4/9] libiscsi: fix iscsi host workq destruction Mike Christie
2021-02-07 4:46 ` [PATCH 5/9] libiscsi: add helper to calc max scsi cmds per session Mike Christie
2021-02-07 4:46 ` [PATCH 6/9] iscsi_tcp: fix shost can_queue initialization Mike Christie
2021-02-07 4:46 ` [PATCH 7/9] libiscsi: reset max/exp cmdsn during recovery Mike Christie
2021-02-07 4:46 ` Mike Christie [this message]
2021-02-07 4:46 ` [PATCH 9/9] iscsi class: drop session lock in iscsi_session_chkready Mike Christie
2021-02-09 3:41 ` [PATCH 0/9 V6] iscsi fixes and cleanups Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2021-02-03 1:33 [PATCH 0/9 V5] " Mike Christie
2021-02-03 1:33 ` [PATCH 8/9] qla4xxx: use iscsi_is_session_online Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210207044608.27585-9-michael.christie@oracle.com \
--to=michael.christie@oracle.com \
--cc=cleech@redhat.com \
--cc=haowenchao@huawei.com \
--cc=james.bottomley@hansenpartnership.com \
--cc=lduncan@suse.com \
--cc=linfeilong@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=liuzhiqiang26@huawei.com \
--cc=lutianxiong@huawei.com \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.