Re: [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read()

From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [RFC PATCH 5/8] ext4: use memcpy_from_page() in pagecache_read()
Date: Mon, 08 Feb 2021 09:45:46 +0800	[thread overview]
Message-ID: <202102080914.Gi3k8eCp-lkp@intel.com> (raw)
In-Reply-To: <20210207190425.38107-6-chaitanya.kulkarni@wdc.com>

[-- Attachment #1: Type: text/plain, Size: 2653 bytes --]

Hi Chaitanya,

[FYI, it's a private test report for your RFC patch.]
[auto build test ERROR on block/for-next]
[also build test ERROR on ext4/dev f2fs/dev-test v5.11-rc6 next-20210125]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chaitanya-Kulkarni/use-core-page-calls-instead-of-kmaps/20210208-030809
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-randconfig-m021-20210207 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/f431d96c961282073b7a3ab50f622f541f0fa513
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chaitanya-Kulkarni/use-core-page-calls-instead-of-kmaps/20210208-030809
        git checkout f431d96c961282073b7a3ab50f622f541f0fa513
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   fs/ext4/verity.c: In function 'pagecache_read':
>> fs/ext4/verity.c:54:3: error: implicit declaration of function 'memcpy_from_page'; did you mean 'memcpy_fromio'? [-Werror=implicit-function-declaration]
      54 |   memcpy_from_page(buf, page, offset_in_page(pos), n);
         |   ^~~~~~~~~~~~~~~~
         |   memcpy_fromio
   cc1: some warnings being treated as errors

vim +54 fs/ext4/verity.c

    36	
    37	/*
    38	 * Read some verity metadata from the inode.  __vfs_read() can't be used because
    39	 * we need to read beyond i_size.
    40	 */
    41	static int pagecache_read(struct inode *inode, void *buf, size_t count,
    42				  loff_t pos)
    43	{
    44		while (count) {
    45			size_t n = min_t(size_t, count,
    46					 PAGE_SIZE - offset_in_page(pos));
    47			struct page *page;
    48	
    49			page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT,
    50						 NULL);
    51			if (IS_ERR(page))
    52				return PTR_ERR(page);
    53	
  > 54			memcpy_from_page(buf, page, offset_in_page(pos), n);
    55	
    56			put_page(page);
    57	
    58			buf += n;
    59			pos += n;
    60			count -= n;
    61		}
    62		return 0;
    63	}
    64	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 38404 bytes --]