From: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Andreas Konopik <andreas.konopik@efs-auto.de>,
Richard Henderson <richard.henderson@linaro.org>,
qemu-devel@nongnu.org, Joe Komlodi <komlodi@xilinx.com>,
David Brenken <david.brenken@efs-auto.org>
Subject: Re: [PATCH 2/3] target/tricore: Pass MMUAccessType to get_physical_address()
Date: Wed, 10 Feb 2021 13:09:07 +0100 [thread overview]
Message-ID: <20210210120907.rnoqzlyjfcadunmq@schnipp-desktop> (raw)
In-Reply-To: <20210127224255.3505711-3-f4bug@amsat.org>
On Wed, Jan 27, 2021 at 11:42:54PM +0100, Philippe Mathieu-Daudé wrote:
> 'int access_type' and ACCESS_INT are unused, drop them.
> Provide the mmu_idx argument to match other targets.
> 'int rw' is actually the MMUAccessType, rename it.
>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> target/tricore/helper.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
Reviewed-by: Bastian Koppelmann <kbastian@mail.uni-paderborn.de>
Cheers,
Bastian
next prev parent reply other threads:[~2021-02-10 12:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 22:42 [PATCH 0/3] target/tricore: Pass MMUAccessType to get_physical_address() Philippe Mathieu-Daudé
2021-01-27 22:42 ` [PATCH 1/3] target/tricore: Replace magic value by MMU_DATA_LOAD definition Philippe Mathieu-Daudé
2021-02-10 12:00 ` Bastian Koppelmann
2021-01-27 22:42 ` [PATCH 2/3] target/tricore: Pass MMUAccessType to get_physical_address() Philippe Mathieu-Daudé
2021-02-10 12:09 ` Bastian Koppelmann [this message]
2021-01-27 22:42 ` [PATCH 3/3] target/tricore: Remove unused definitions Philippe Mathieu-Daudé
2021-02-10 12:10 ` Bastian Koppelmann
2021-02-10 11:19 ` [PATCH 0/3] target/tricore: Pass MMUAccessType to get_physical_address() Philippe Mathieu-Daudé
2021-02-10 12:12 ` Bastian Koppelmann
2021-03-09 22:46 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210120907.rnoqzlyjfcadunmq@schnipp-desktop \
--to=kbastian@mail.uni-paderborn.de \
--cc=andreas.konopik@efs-auto.de \
--cc=david.brenken@efs-auto.org \
--cc=f4bug@amsat.org \
--cc=komlodi@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.