From: David Sterba <dsterba@suse.cz>
To: Qu Wenruo <wqu@suse.com>
Cc: linux-btrfs@vger.kernel.org, Nikolay Borisov <nborisov@suse.com>
Subject: Re: [PATCH v2] btrfs: rework the order of btrfs_ordered_extent::flags
Date: Thu, 11 Feb 2021 00:33:42 +0100 [thread overview]
Message-ID: <20210210233342.GB1993@twin.jikos.cz> (raw)
In-Reply-To: <20210126003545.8885-1-wqu@suse.com>
On Tue, Jan 26, 2021 at 08:35:45AM +0800, Qu Wenruo wrote:
> --- a/fs/btrfs/ordered-data.h
> +++ b/fs/btrfs/ordered-data.h
> @@ -27,7 +27,7 @@ struct btrfs_ordered_sum {
> };
>
> /*
> - * bits for the flags field:
> + * Bits for btrfs_ordered_extent::flags.
> *
> * BTRFS_ORDERED_IO_DONE is set when all of the blocks are written.
> * It is used to make sure metadata is inserted into the tree only once
> @@ -38,24 +38,36 @@ struct btrfs_ordered_sum {
> * IO is done and any metadata is inserted into the tree.
> */
> enum {
> + /*
> + * Different types for ordered extent, one and only one of the 4 types
> + * can be set when creating ordered extent.
Sorry, I did not merge this followup in time for the 5.12 freeze and now
it would be too late to rebase the whole branch just to fix a comment.
The difference is 'types for direct io' and the 'the 4 type' (typo).
Please send an incremental patch, the comment would be incorrect and is
worth fixing. Thanks.
prev parent reply other threads:[~2021-02-10 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 0:35 [PATCH v2] btrfs: rework the order of btrfs_ordered_extent::flags Qu Wenruo
2021-02-10 23:33 ` David Sterba [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210233342.GB1993@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
--cc=wqu@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.