From: "Darrick J. Wong" <djwong@kernel.org>
To: Brian Foster <bfoster@redhat.com>
Cc: guaneryu@gmail.com, linux-xfs@vger.kernel.org,
fstests@vger.kernel.org, guan@eryu.me
Subject: Re: [PATCH 5/6] check: run tests in exactly the order specified
Date: Thu, 11 Feb 2021 09:28:06 -0800 [thread overview]
Message-ID: <20210211172806.GJ7190@magnolia> (raw)
In-Reply-To: <20210211140045.GE222065@bfoster>
On Thu, Feb 11, 2021 at 09:00:45AM -0500, Brian Foster wrote:
> On Tue, Feb 09, 2021 at 06:56:47PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Introduce a new --exact-order switch to disable all sorting, filtering
> > of repeated lines, and shuffling of test order. The goal of this is to
> > be able to run tests in a specific order, namely to try to reproduce
> > test failures that could be the result of a -r(andomize) run getting
> > lucky.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> > ---
> > check | 36 ++++++++++++++++++++++++++++--------
> > 1 file changed, 28 insertions(+), 8 deletions(-)
> >
> >
> > diff --git a/check b/check
> > index 6f8db858..106ec8e1 100755
> > --- a/check
> > +++ b/check
> ...
> > @@ -249,17 +251,22 @@ _prepare_test_list()
> > trim_test_list $list
> > done
> >
> > - # sort the list of tests into numeric order
> > - if $randomize; then
> > - if type shuf >& /dev/null; then
> > - sorter="shuf"
> > + # sort the list of tests into numeric order unless we're running tests
> > + # in the exact order specified
> > + if ! $exact_order; then
> > + if $randomize; then
> > + if type shuf >& /dev/null; then
> > + sorter="shuf"
> > + else
> > + sorter="awk -v seed=$RANDOM -f randomize.awk"
> > + fi
> > else
> > - sorter="awk -v seed=$RANDOM -f randomize.awk"
> > + sorter="cat"
> > fi
> > + list=`sort -n $tmp.list | uniq | $sorter`
> > else
> > - sorter="cat"
> > + list=`cat $tmp.list`
>
> Do we want to still filter out duplicates (i.e. uniq) in exact order
> mode? LGTM either way:
I figure --exact-order means to run exactly what the user specified,
duplicates and all.
--D
>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
>
> > fi
> > - list=`sort -n $tmp.list | uniq | $sorter`
> > rm -f $tmp.list
> > }
> >
> > @@ -304,7 +311,20 @@ while [ $# -gt 0 ]; do
> > -udiff) diff="$diff -u" ;;
> >
> > -n) showme=true ;;
> > - -r) randomize=true ;;
> > + -r)
> > + if $exact_order; then
> > + echo "Cannot specify -r and --exact-order."
> > + exit 1
> > + fi
> > + randomize=true
> > + ;;
> > + --exact-order)
> > + if $randomize; then
> > + echo "Cannnot specify --exact-order and -r."
> > + exit 1
> > + fi
> > + exact_order=true
> > + ;;
> > -i) iterations=$2; shift ;;
> > -T) timestamp=true ;;
> > -d) DUMP_OUTPUT=true ;;
> >
>
next prev parent reply other threads:[~2021-02-11 17:30 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 2:56 [PATCHSET 0/6] fstests: various improvements to the test framework Darrick J. Wong
2021-02-10 2:56 ` [PATCH 1/6] config: wrap xfs_metadump as $XFS_METADUMP_PROG like the other tools Darrick J. Wong
2021-02-11 13:58 ` Brian Foster
2021-02-10 2:56 ` [PATCH 2/6] common: capture metadump output if xfs filesystem check fails Darrick J. Wong
2021-02-11 13:59 ` Brian Foster
2021-02-11 18:12 ` Darrick J. Wong
2021-02-11 18:35 ` Brian Foster
2021-02-11 19:05 ` Darrick J. Wong
2021-02-10 2:56 ` [PATCH 3/6] check: allow '-e testid' to exclude a single test Darrick J. Wong
2021-02-11 14:00 ` Brian Foster
2021-02-10 2:56 ` [PATCH 4/6] check: don't abort on non-existent excluded groups Darrick J. Wong
2021-02-11 14:00 ` Brian Foster
2021-02-11 17:27 ` Darrick J. Wong
2021-02-11 18:01 ` Brian Foster
2021-02-10 2:56 ` [PATCH 5/6] check: run tests in exactly the order specified Darrick J. Wong
2021-02-11 14:00 ` Brian Foster
2021-02-11 17:28 ` Darrick J. Wong [this message]
2021-02-10 2:56 ` [PATCH 6/6] fuzzy: capture core dumps from repair utilities Darrick J. Wong
2021-02-11 14:00 ` Brian Foster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211172806.GJ7190@magnolia \
--to=djwong@kernel.org \
--cc=bfoster@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.