All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	"Cleber Rosa" <crosa@redhat.com>,
	f4bug@amsat.org,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	stefanha@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	pbonzini@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
	aurelien@aurel32.net
Subject: [PATCH v1 6/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test
Date: Wed, 17 Feb 2021 12:19:32 +0000	[thread overview]
Message-ID: <20210217121932.19986-7-alex.bennee@linaro.org> (raw)
In-Reply-To: <20210217121932.19986-1-alex.bennee@linaro.org>

This is a band-aid with a TODO for cases when QEMU doesn't start due
to missing VirGL. Longer term we could do with some proper feature
probing.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 tests/acceptance/virtio-gpu.py | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/tests/acceptance/virtio-gpu.py b/tests/acceptance/virtio-gpu.py
index ab1a4c1a71..ab18cddbb7 100644
--- a/tests/acceptance/virtio-gpu.py
+++ b/tests/acceptance/virtio-gpu.py
@@ -85,7 +85,12 @@ def test_virtio_vga_virgl(self):
             "-append",
             kernel_command_line,
         )
-        self.vm.launch()
+        try:
+            self.vm.launch()
+        except:
+            # TODO: probably fails because we are missing the VirGL features
+            self.cancel("VirGL not enabled?")
+
         self.wait_for_console_pattern("as init process")
         exec_command_and_wait_for_pattern(
             self, "/usr/sbin/modprobe virtio_gpu", ""
-- 
2.20.1



  parent reply	other threads:[~2021-02-17 12:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 12:19 [PATCH v1 0/6] my current testing/next queue (meson/gitlab/fedora bump) Alex Bennée
2021-02-17 12:19 ` [PATCH v1 1/6] meson.build: expose TCG cross compiler information in summary Alex Bennée
2021-02-17 12:19 ` [PATCH v1 2/6] gitlab-ci: Display Avocado log content when tests timeout Alex Bennée
2021-02-17 13:38   ` Thomas Huth
2021-02-17 12:19 ` [PATCH v1 3/6] gitlab-ci.yml: Run check-tcg with TCI Alex Bennée
2021-02-17 16:38   ` Philippe Mathieu-Daudé
2021-02-17 17:51   ` Richard Henderson
2021-02-17 12:19 ` [PATCH v1 4/6] docker: Bump Fedora images to release 33 Alex Bennée
2021-02-17 12:19 ` [PATCH v1 5/6] travis.yml: Limit simultaneous jobs to 3 Alex Bennée
2021-02-17 12:19 ` Alex Bennée [this message]
2021-02-17 13:20   ` [PATCH v1 6/6] tests/acceptance: allow a "graceful" failing for virtio-gpu test Marc-André Lureau
2021-02-19 15:53   ` Willian Rampazzo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210217121932.19986-7-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=marcandre.lureau@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=philmd@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.