From: Kalle Valo <kvalo@codeaurora.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 5.12 1/2] mt76: fix tx skb error handling in mt76_dma_tx_queue_skb
Date: Thu, 18 Feb 2021 06:09:43 +0000 (UTC) [thread overview]
Message-ID: <20210218060943.E0416C433CA@smtp.codeaurora.org> (raw)
In-Reply-To: <20210216135119.23809-1-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> wrote:
> When running out of room in the tx queue after calling drv->tx_prepare_skb,
> the buffer list will already have been modified on MT7615 and newer drivers.
> This can leak a DMA mapping and will show up as swiotlb allocation failures
> on x86.
>
> Fix this by moving the queue length check further up. This is less accurate,
> since it can overestimate the needed room in the queue on MT7615 and newer,
> but the difference is small enough to not matter in practice.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
2 patches applied to wireless-drivers.git, thanks.
ae064fc0e32a mt76: fix tx skb error handling in mt76_dma_tx_queue_skb
94f0e6256c2a mt76: mt7915: only modify tx buffer list after allocating tx token id
--
https://patchwork.kernel.org/project/linux-wireless/patch/20210216135119.23809-1-nbd@nbd.name/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2021-02-18 6:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 13:51 [PATCH 5.12 1/2] mt76: fix tx skb error handling in mt76_dma_tx_queue_skb Felix Fietkau
2021-02-16 13:51 ` [PATCH 5.12 2/2] mt76: mt7915: only modify tx buffer list after allocating tx token id Felix Fietkau
2021-02-18 6:09 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218060943.E0416C433CA@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.