From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: [PATCH 3/6] ASoC: soc-pcm: remove shadowing variable
Date: Thu, 18 Feb 2021 16:19:18 -0600 [thread overview]
Message-ID: <20210218221921.88991-4-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210218221921.88991-1-pierre-louis.bossart@linux.intel.com>
cppcheck warning:
sound/soc/soc-pcm.c:1718:7: style: Local variable 'i' shadows outer
variable [shadowVariable]
int i;
^
sound/soc/soc-pcm.c:1696:6: note: Shadowed declaration
int i;
^
sound/soc/soc-pcm.c:1718:7: note: Shadow variable
int i;
^
the second variable seems totally unnecessary.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/soc-pcm.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
index 12fd10a6c190..705fb2d548a9 100644
--- a/sound/soc/soc-pcm.c
+++ b/sound/soc/soc-pcm.c
@@ -1718,7 +1718,6 @@ static int dpcm_apply_symmetry(struct snd_pcm_substream *fe_substream,
snd_soc_dpcm_get_substream(be, stream);
struct snd_soc_pcm_runtime *rtd;
struct snd_soc_dai *dai;
- int i;
/* A backend may not have the requested substream */
if (!be_substream)
--
2.25.1
next prev parent reply other threads:[~2021-02-18 22:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-18 22:19 [PATCH 0/6] ASoC: core: remove cppcheck warnings Pierre-Louis Bossart
2021-02-18 22:19 ` [PATCH 1/6] ASoC: soc-ops: remove useless assignment Pierre-Louis Bossart
2021-02-18 22:19 ` [PATCH 2/6] ASoC: soc-pcm: remove redundant assignment Pierre-Louis Bossart
2021-02-18 22:19 ` Pierre-Louis Bossart [this message]
2021-02-18 22:19 ` [PATCH 4/6] ASoC: soc-pcm: add error log Pierre-Louis Bossart
2021-02-18 22:19 ` [PATCH 5/6] ASoC: soc-topology: clarify expression Pierre-Louis Bossart
2021-02-18 22:19 ` [PATCH 6/6] ASoC: generic: simple-card-utils: remove useless assignment Pierre-Louis Bossart
2021-03-01 23:34 ` [PATCH 0/6] ASoC: core: remove cppcheck warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210218221921.88991-4-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.