From: Vladimir Oltean <olteanv@gmail.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Russell King <linux@armlinux.org.uk>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2 2/2] net: dsa: b53: Support setting learning on port
Date: Tue, 23 Feb 2021 01:18:32 +0200 [thread overview]
Message-ID: <20210222231832.fzrq3y3vbok5byd3@skbuf> (raw)
In-Reply-To: <20210222223010.2907234-3-f.fainelli@gmail.com>
On Mon, Feb 22, 2021 at 02:30:10PM -0800, Florian Fainelli wrote:
> diff --git a/drivers/net/dsa/b53/b53_regs.h b/drivers/net/dsa/b53/b53_regs.h
> index c90985c294a2..b2c539a42154 100644
> --- a/drivers/net/dsa/b53/b53_regs.h
> +++ b/drivers/net/dsa/b53/b53_regs.h
> @@ -115,6 +115,7 @@
> #define B53_UC_FLOOD_MASK 0x32
> #define B53_MC_FLOOD_MASK 0x34
> #define B53_IPMC_FLOOD_MASK 0x36
> +#define B53_DIS_LEARNING 0x3c
>
> /*
> * Override Ports 0-7 State on devices with xMII interfaces (8 bit)
> diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
> index 3eaedbb12815..5ee8103b8e9c 100644
> --- a/drivers/net/dsa/bcm_sf2.c
> +++ b/drivers/net/dsa/bcm_sf2.c
> @@ -223,23 +223,10 @@ static int bcm_sf2_port_setup(struct dsa_switch *ds, int port,
> reg &= ~P_TXQ_PSM_VDD(port);
> core_writel(priv, reg, CORE_MEM_PSM_VDD_CTRL);
>
> - /* Enable learning */
> - reg = core_readl(priv, CORE_DIS_LEARN);
> - reg &= ~BIT(port);
> - core_writel(priv, reg, CORE_DIS_LEARN);
> -
> /* Enable Broadcom tags for that port if requested */
> - if (priv->brcm_tag_mask & BIT(port)) {
> + if (priv->brcm_tag_mask & BIT(port))
> b53_brcm_hdr_setup(ds, port);
>
> - /* Disable learning on ASP port */
> - if (port == 7) {
> - reg = core_readl(priv, CORE_DIS_LEARN);
> - reg |= BIT(port);
> - core_writel(priv, reg, CORE_DIS_LEARN);
> - }
> - }
> -
In sf2, CORE_DIS_LEARN is at address 0xf0, while in b53, B53_DIS_LEARN
is at 0x3c. Are they even configuring the same thing?
next prev parent reply other threads:[~2021-02-22 23:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-22 22:30 [PATCH net v2 0/2] net: dsa: Learning fixes for b53/bcm_sf2 Florian Fainelli
2021-02-22 22:30 ` [PATCH net v2 1/2] net: dsa: bcm_sf2: Wire-up br_flags_pre, br_flags and set_mrouter Florian Fainelli
2021-02-22 23:10 ` Vladimir Oltean
2021-02-22 22:30 ` [PATCH net v2 2/2] net: dsa: b53: Support setting learning on port Florian Fainelli
2021-02-22 23:18 ` Vladimir Oltean [this message]
2021-02-22 23:44 ` Florian Fainelli
2021-02-23 0:10 ` Vladimir Oltean
2021-02-23 20:27 ` [PATCH net v2 0/2] net: dsa: Learning fixes for b53/bcm_sf2 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210222231832.fzrq3y3vbok5byd3@skbuf \
--to=olteanv@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.