From: Julien Grall <julien@xen.org>
To: xen-devel@lists.xenproject.org
Cc: hongyxia@amazon.co.uk, iwj@xenproject.org,
Julien Grall <jgrall@amazon.com>, Jan Beulich <jbeulich@suse.com>,
Paul Durrant <paul@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Kevin Tian <kevin.tian@intel.com>
Subject: [PATCH for-4.15 v5 0/3] xen/iommu: Collection of bug fixes for IOMMU teardown
Date: Fri, 26 Feb 2021 10:56:37 +0000 [thread overview]
Message-ID: <20210226105640.12037-1-julien@xen.org> (raw)
From: Julien Grall <jgrall@amazon.com>
Hi all,
This series is a collection of bug fixes for the IOMMU teardown code.
All of them are candidate for 4.15 as they can either leak memory or
lead to host crash/host corruption.
This is sent directly on xen-devel because all the issues were either
introduced in 4.15 or happen in the domain creation code.
Major changes since v4:
- New patch added (it is a split of patch #1 in v4)
Major changes since v3:
- Remove patch #3 "xen/iommu: x86: Harden the IOMMU page-table
allocator" as it is not strictly necessary for 4.15.
- Re-order the patches to avoid on a follow-up patch to fix
completely the issue.
Major changes since v2:
- patch #1 "xen/x86: p2m: Don't map the special pages in the IOMMU
page-tables" has been removed. This requires Jan's patch [1] to
fully mitigate memory leaks.
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
@Ian, I assumed that the release-acked-by would stand even with the
patch split. Let me know if if this is not the case.
Cheers,
[1] <90271e69-c07e-a32c-5531-a79b10ef03dd@suse.com>
Julien Grall (3):
xen/iommu: x86: Don't try to free page tables is the IOMMU is not
enabled
xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying
xen/iommu: x86: Clear the root page-table before freeing the
page-tables
xen/drivers/passthrough/amd/iommu_map.c | 12 +++++++++++
xen/drivers/passthrough/amd/pci_amd_iommu.c | 12 ++++++++++-
xen/drivers/passthrough/vtd/iommu.c | 24 ++++++++++++++++++++-
xen/drivers/passthrough/x86/iommu.c | 19 ++++++++++++++++
xen/include/xen/iommu.h | 1 +
5 files changed, 66 insertions(+), 2 deletions(-)
--
2.17.1
next reply other threads:[~2021-02-26 10:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 10:56 Julien Grall [this message]
2021-02-26 10:56 ` [PATCH for-4.15 v5 1/3] xen/iommu: x86: Don't try to free page tables is the IOMMU is not enabled Julien Grall
2021-02-26 13:27 ` Jan Beulich
2021-02-26 10:56 ` [PATCH for-4.15 v5 2/3] xen/x86: iommu: Ignore IOMMU mapping requests when a domain is dying Julien Grall
2021-02-26 13:30 ` Jan Beulich
2021-03-01 9:21 ` Julien Grall
2021-03-01 2:52 ` Tian, Kevin
2021-02-26 10:56 ` [PATCH for-4.15 v5 3/3] xen/iommu: x86: Clear the root page-table before freeing the page-tables Julien Grall
2021-03-01 2:54 ` Tian, Kevin
2021-03-02 9:56 ` [PATCH for-4.15 v5 0/3] xen/iommu: Collection of bug fixes for IOMMU teardown Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210226105640.12037-1-julien@xen.org \
--to=julien@xen.org \
--cc=andrew.cooper3@citrix.com \
--cc=hongyxia@amazon.co.uk \
--cc=iwj@xenproject.org \
--cc=jbeulich@suse.com \
--cc=jgrall@amazon.com \
--cc=kevin.tian@intel.com \
--cc=paul@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.