All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Xu Wang <vulab@iscas.ac.cn>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs: Use WARN(1,...)
Date: Fri, 26 Feb 2021 12:10:35 +0000	[thread overview]
Message-ID: <20210226121035.GA2723601@casper.infradead.org> (raw)
In-Reply-To: <20210226094949.49372-1-vulab@iscas.ac.cn>

On Fri, Feb 26, 2021 at 09:49:49AM +0000, Xu Wang wrote:
> Use WARN(1,...) rather than printk followed by WARN_ON(1).

This description doesn't match the patch.

> -	WARN(1, KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} "
> +	WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} "


  reply	other threads:[~2021-02-26 12:12 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26  9:49 [PATCH] fs: Use WARN(1,...) Xu Wang
2021-02-26 12:10 ` Matthew Wilcox [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-02-26  9:49 Xu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226121035.GA2723601@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.