From: Mark Brown <broonie@kernel.org>
To: Kuldeep Singh <kuldeep.singh@nxp.com>
Cc: "linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Ashish Kumar <ashish.kumar@nxp.com>, Han Xu <han.xu@nxp.com>
Subject: Re: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl
Date: Mon, 1 Mar 2021 17:11:11 +0000 [thread overview]
Message-ID: <20210301171111.GE4628@sirena.org.uk> (raw)
In-Reply-To: <DB6PR0402MB2758C61D8320CD0A88DC3B38E09A9@DB6PR0402MB2758.eurprd04.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On Mon, Mar 01, 2021 at 04:39:18PM +0000, Kuldeep Singh wrote:
> > That's a DT binding YAML conversion patch, why would there be a
> > dependency on it?
> I have converted bindings to yaml version in the patch and also added imx8dxl compatible along-with the conversion. Please see the difference in compatible entries from txt to yaml conversion[1].
> Kindly let me know do I need to submit different patch for adding new compatible or ok to include in the conversion patch itself?
Your YAML binding conversion should have been a standalone patch only
doing that conversion, the new compatible should have been split out and
gone first - each patch should only do one thing as covered in
submitting-patches.rst. As things stand the changelog for the
conversion is misleading since it doesn't mention the new compatible.
Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns. Doing this makes your messages much
easier to read and reply to.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-02 0:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-01 10:32 [PATCH 0/3] NXP Flexspi driver patches Kuldeep Singh
2021-03-01 10:32 ` [PATCH 1/3] spi: spi-nxp-fspi: Add support for IP read only Kuldeep Singh
2021-03-01 10:32 ` [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl Kuldeep Singh
2021-03-01 13:25 ` Mark Brown
2021-03-01 16:39 ` [EXT] " Kuldeep Singh
2021-03-01 17:11 ` Mark Brown [this message]
2021-03-02 5:19 ` Kuldeep Singh
2021-03-01 10:32 ` [PATCH 3/3] spi: spi-nxp-fspi: Implement errata workaround for LS1028A Kuldeep Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301171111.GE4628@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ashish.kumar@nxp.com \
--cc=han.xu@nxp.com \
--cc=kuldeep.singh@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.