From: Bard Liao <yung-chuan.liao@linux.intel.com>
To: broonie@kernel.org, tiwai@suse.de
Cc: vkoul@kernel.org, alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, bard.liao@intel.com
Subject: [PATCH 07/11] soundwire: generic_bandwidth_allocation: remove useless init
Date: Tue, 2 Mar 2021 17:11:18 +0800 [thread overview]
Message-ID: <20210302091122.13952-8-yung-chuan.liao@linux.intel.com> (raw)
In-Reply-To: <20210302091122.13952-1-yung-chuan.liao@linux.intel.com>
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cppcheck complains about two possible null pointer dereferences, but
it's more like there are unnecessary initializations before walking
through a list.
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Signed-off-by: Bard Liao <yung-chuan.liao@linux.intel.com>
---
drivers/soundwire/generic_bandwidth_allocation.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soundwire/generic_bandwidth_allocation.c b/drivers/soundwire/generic_bandwidth_allocation.c
index 0bdef38c9a30..f3d13bb2cefe 100644
--- a/drivers/soundwire/generic_bandwidth_allocation.c
+++ b/drivers/soundwire/generic_bandwidth_allocation.c
@@ -143,7 +143,7 @@ static void sdw_compute_master_ports(struct sdw_master_runtime *m_rt,
static void _sdw_compute_port_params(struct sdw_bus *bus,
struct sdw_group_params *params, int count)
{
- struct sdw_master_runtime *m_rt = NULL;
+ struct sdw_master_runtime *m_rt;
int hstop = bus->params.col - 1;
int block_offset, port_bo, i;
@@ -169,7 +169,7 @@ static int sdw_compute_group_params(struct sdw_bus *bus,
struct sdw_group_params *params,
int *rates, int count)
{
- struct sdw_master_runtime *m_rt = NULL;
+ struct sdw_master_runtime *m_rt;
int sel_col = bus->params.col;
unsigned int rate, bps, ch;
int i, column_needed = 0;
--
2.17.1
next prev parent reply other threads:[~2021-03-02 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 9:11 [PATCH 00/11] soundwire: some cleanup patches Bard Liao
2021-03-02 9:11 ` [PATCH 01/11] soundwire: bus: use correct driver name in error messages Bard Liao
2021-03-02 9:11 ` [PATCH 02/11] soundwire: bus: test read status Bard Liao
2021-03-02 9:11 ` [PATCH 03/11] soundwire: bus: use consistent tests for return values Bard Liao
2021-03-02 9:11 ` [PATCH 04/11] soundwire: bus: demote clock stop prepare log to dev_dbg() Bard Liao
2021-03-02 9:11 ` [PATCH 05/11] soundwire: bus: uniquify dev_err() for SCP_INT access Bard Liao
2021-03-02 9:11 ` [PATCH 06/11] soundwire: bus: remove useless initialization Bard Liao
2021-03-02 9:11 ` Bard Liao [this message]
2021-03-02 9:11 ` [PATCH 08/11] soundwire: intel: remove useless readl Bard Liao
2021-03-02 9:11 ` [PATCH 09/11] soundwire: qcom: check of_property_read status Bard Liao
2021-03-02 9:11 ` [PATCH 10/11] soundwire: stream: remove useless initialization Bard Liao
2021-03-02 9:11 ` [PATCH 11/11] soundwire: stream: remove useless bus initializations Bard Liao
2021-03-30 6:21 ` [PATCH 00/11] soundwire: some cleanup patches Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302091122.13952-8-yung-chuan.liao@linux.intel.com \
--to=yung-chuan.liao@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.