From: Fangrui Song <maskray@google.com>
To: Nathan Chancellor <nathan@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com,
Sedat Dilek <sedat.dilek@gmail.com>
Subject: Re: [PATCH v2 1/2] Makefile: Remove '--gcc-toolchain' flag
Date: Tue, 9 Mar 2021 13:15:27 -0800 [thread overview]
Message-ID: <20210309211527.us52fgxdzpf25xzw@google.com> (raw)
In-Reply-To: <20210309205915.2340265-1-nathan@kernel.org>
On 2021-03-09, Nathan Chancellor wrote:
>This flag was originally added to allow clang to find the GNU cross
>tools in commit 785f11aa595b ("kbuild: Add better clang cross build
>support"). This flag was not enough to find the tools at times so
>'--prefix' was added to the list in commit ef8c4ed9db80 ("kbuild: allow
>to use GCC toolchain not in Clang search path") and improved upon in
>commit ca9b31f6bb9c ("Makefile: Fix GCC_TOOLCHAIN_DIR prefix for Clang
>cross compilation"). Now that '--prefix' specifies a full path and
>prefix, '--gcc-toolchain' serves no purpose because the kernel builds
>with '-nostdinc' and '-nostdlib'.
>
>This has been verified with self compiled LLVM 10.0.1 and LLVM 13.0.0 as
>well as a distribution version of LLVM 11.1.0 without binutils in the
>LLVM toolchain locations.
>
>Link: https://reviews.llvm.org/D97902
>Signed-off-by: Nathan Chancellor <nathan@kernel.org>
The wording looks good.
Reviewed-by: Fangrui Song <maskray@google.com>
next prev parent reply other threads:[~2021-03-09 21:16 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-02 21:06 [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag Nathan Chancellor
2021-03-02 21:06 ` [PATCH 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as Nathan Chancellor
2021-03-02 22:02 ` Fangrui Song
2021-03-02 22:09 ` Nick Desaulniers
2021-03-02 22:40 ` Nick Desaulniers
2021-03-09 19:55 ` Masahiro Yamada
2021-03-09 19:58 ` Masahiro Yamada
2021-09-29 17:26 ` kernel test robot
2021-09-29 17:26 ` kernel test robot
2021-09-29 19:32 ` kernel test robot
2021-09-29 19:32 ` kernel test robot
2021-03-02 21:43 ` [PATCH 1/2] Makefile: Remove '--gcc-toolchain' flag Fangrui Song
2021-03-03 8:33 ` Masahiro Yamada
2021-03-02 22:33 ` Nick Desaulniers
2021-03-03 3:25 ` Sedat Dilek
2021-03-03 14:22 ` Sedat Dilek
2021-03-09 20:59 ` [PATCH v2 " Nathan Chancellor
2021-03-09 20:59 ` [PATCH v2 2/2] Makefile: Only specify '--prefix=' when building with clang + GNU as Nathan Chancellor
2021-03-09 21:15 ` Fangrui Song [this message]
2021-03-15 16:21 ` [PATCH v2 1/2] Makefile: Remove '--gcc-toolchain' flag Masahiro Yamada
2021-03-15 16:41 ` Sedat Dilek
2021-03-16 15:36 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210309211527.us52fgxdzpf25xzw@google.com \
--to=maskray@google.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=sedat.dilek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.