All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
To: Dave Stevenson <dave.stevenson@raspberrypi.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Pavel Machek <pavel@denx.de>,
	Andrey Konovalov <andrey.konovalov@linaro.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jacopo Mondi <jacopo@jmondi.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-renesas-soc@vger.kernel.org,
	Prabhakar <prabhakar.csengg@gmail.com>,
	Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	Biju Das <biju.das.jz@bp.renesas.com>
Subject: [PATCH 1/3] media: i2c: imx219: Enable vflip and hflip controls on stream stop
Date: Wed, 10 Mar 2021 12:20:12 +0000	[thread overview]
Message-ID: <20210310122014.28353-2-prabhakar.mahadev-lad.rj@bp.renesas.com> (raw)
In-Reply-To: <20210310122014.28353-1-prabhakar.mahadev-lad.rj@bp.renesas.com>

Enable vflip and hflip controls in resume error path when streaming
is stopped.

Fixes: 1283b3b8f82b9 ("media: i2c: Add driver for Sony IMX219 sensor")
Reported-by: Pavel Machek <pavel@denx.de>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/media/i2c/imx219.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/media/i2c/imx219.c b/drivers/media/i2c/imx219.c
index 6e3382b85a90..f0cf1985a4dc 100644
--- a/drivers/media/i2c/imx219.c
+++ b/drivers/media/i2c/imx219.c
@@ -1195,6 +1195,8 @@ static int __maybe_unused imx219_resume(struct device *dev)
 error:
 	imx219_stop_streaming(imx219);
 	imx219->streaming = false;
+	__v4l2_ctrl_grab(imx219->vflip, false);
+	__v4l2_ctrl_grab(imx219->hflip, false);
 
 	return ret;
 }
-- 
2.17.1


  reply	other threads:[~2021-03-10 12:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 12:20 [PATCH 0/3] media: i2c: imx219: Trivial Fixes Lad Prabhakar
2021-03-10 12:20 ` Lad Prabhakar [this message]
2021-03-10 12:44   ` [PATCH 1/3] media: i2c: imx219: Enable vflip and hflip controls on stream stop Laurent Pinchart
2021-03-10 14:03     ` Lad, Prabhakar
2021-03-10 12:20 ` [PATCH 2/3] media: i2c: imx219: Serialize during stream start/stop Lad Prabhakar
2021-03-10 12:39   ` Laurent Pinchart
2021-03-10 12:46     ` Lad, Prabhakar
2021-03-10 12:54       ` Laurent Pinchart
2021-03-10 13:08         ` Lad, Prabhakar
2021-03-10 12:20 ` [PATCH 3/3] media: i2c: imx219: Balance runtime PM use-count in resume callback Lad Prabhakar
2021-03-10 12:48   ` Laurent Pinchart
2021-03-10 14:01     ` Lad, Prabhakar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210310122014.28353-2-prabhakar.mahadev-lad.rj@bp.renesas.com \
    --to=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=andrey.konovalov@linaro.org \
    --cc=biju.das.jz@bp.renesas.com \
    --cc=dave.stevenson@raspberrypi.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=jacopo@jmondi.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=pavel@denx.de \
    --cc=prabhakar.csengg@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.