Re: [PATCH v25 05/25] LSM: Use lsmblob in security_audit_rule_match

From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH v25 05/25] LSM: Use lsmblob in security_audit_rule_match
Date: Wed, 10 Mar 2021 13:49:44 +0800	[thread overview]
Message-ID: <202103101326.bVqKTC66-lkp@intel.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 2974 bytes --]

CC: kbuild-all(a)lists.01.org
In-Reply-To: <20210309144243.12519-6-casey@schaufler-ca.com>
References: <20210309144243.12519-6-casey@schaufler-ca.com>
TO: Casey Schaufler <casey@schaufler-ca.com>
TO: casey.schaufler(a)intel.com
TO: jmorris(a)namei.org
TO: linux-security-module(a)vger.kernel.org
TO: selinux(a)vger.kernel.org
CC: casey(a)schaufler-ca.com
CC: linux-audit(a)redhat.com
CC: keescook(a)chromium.org
CC: john.johansen(a)canonical.com
CC: penguin-kernel(a)i-love.sakura.ne.jp
CC: paul(a)paul-moore.com

Hi Casey,

I love your patch! Perhaps something to improve:

[auto build test WARNING on nf/master]
[also build test WARNING on linus/master v5.12-rc2 next-20210309]
[cannot apply to pcmoore-audit/next nf-next/master security/next-testing]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-Infrastructure-management-of-the-sock-security/20210309-234224
base:   https://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf.git master
:::::: branch date: 14 hours ago
:::::: commit date: 14 hours ago
config: x86_64-randconfig-m001-20210308 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>

smatch warnings:
include/linux/security.h:166 lsmblob_init() warn: we never enter this loop
include/linux/security.h:166 lsmblob_init() warn: we never enter this loop

vim +166 include/linux/security.h

f18de8b78bc44b Casey Schaufler 2021-03-09  154  
f18de8b78bc44b Casey Schaufler 2021-03-09  155  /**
f18de8b78bc44b Casey Schaufler 2021-03-09  156   * lsmblob_init - initialize an lsmblob structure
f18de8b78bc44b Casey Schaufler 2021-03-09  157   * @blob: Pointer to the data to initialize
f18de8b78bc44b Casey Schaufler 2021-03-09  158   * @secid: The initial secid value
f18de8b78bc44b Casey Schaufler 2021-03-09  159   *
f18de8b78bc44b Casey Schaufler 2021-03-09  160   * Set all secid for all modules to the specified value.
f18de8b78bc44b Casey Schaufler 2021-03-09  161   */
f18de8b78bc44b Casey Schaufler 2021-03-09  162  static inline void lsmblob_init(struct lsmblob *blob, u32 secid)
f18de8b78bc44b Casey Schaufler 2021-03-09  163  {
f18de8b78bc44b Casey Schaufler 2021-03-09  164  	int i;
f18de8b78bc44b Casey Schaufler 2021-03-09  165  
f18de8b78bc44b Casey Schaufler 2021-03-09 @166  	for (i = 0; i < LSMBLOB_ENTRIES; i++)
f18de8b78bc44b Casey Schaufler 2021-03-09  167  		blob->secid[i] = secid;
f18de8b78bc44b Casey Schaufler 2021-03-09  168  }
f18de8b78bc44b Casey Schaufler 2021-03-09  169  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 31463 bytes --]