From: Bjorn Helgaas <helgaas@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] PCI: controller: al: select CONFIG_PCI_ECAM
Date: Wed, 10 Mar 2021 13:32:46 -0600 [thread overview]
Message-ID: <20210310193246.GA2033984@bjorn-Precision-5520> (raw)
In-Reply-To: <20210308152501.2135937-1-arnd@kernel.org>
On Mon, Mar 08, 2021 at 04:24:46PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Compile-testing this driver without ECAM support results in a link
> failure:
>
> ld.lld: error: undefined symbol: pci_ecam_map_bus
> >>> referenced by pcie-al.c
> >>> pci/controller/dwc/pcie-al.o:(al_pcie_map_bus) in archive drivers/built-in.a
>
> Select CONFIG_ECAM like the other drivers do.
Did we add these compile issues in the v5.12-rc1? I.e., are the fixes
candidates for v5.12?
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/pci/controller/dwc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pci/controller/dwc/Kconfig b/drivers/pci/controller/dwc/Kconfig
> index 5a3032d9b844..d981a0eba99f 100644
> --- a/drivers/pci/controller/dwc/Kconfig
> +++ b/drivers/pci/controller/dwc/Kconfig
> @@ -311,6 +311,7 @@ config PCIE_AL
> depends on OF && (ARM64 || COMPILE_TEST)
> depends on PCI_MSI_IRQ_DOMAIN
> select PCIE_DW_HOST
> + select PCI_ECAM
> help
> Say Y here to enable support of the Amazon's Annapurna Labs PCIe
> controller IP on Amazon SoCs. The PCIe controller uses the DesignWare
> --
> 2.29.2
>
next prev parent reply other threads:[~2021-03-10 19:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 15:24 [PATCH 1/3] PCI: controller: al: select CONFIG_PCI_ECAM Arnd Bergmann
2021-03-08 15:24 ` [PATCH 2/3] [RESEND] PCI: controller: thunder: fix compile testing Arnd Bergmann
2021-03-08 15:24 ` Arnd Bergmann
2021-03-08 15:24 ` [PATCH 3/3] [RESEND] PCI: controller: avoid building empty drivers Arnd Bergmann
2021-03-08 23:11 ` [PATCH 1/3] PCI: controller: al: select CONFIG_PCI_ECAM Krzysztof Wilczyński
2021-03-10 19:32 ` Bjorn Helgaas [this message]
2021-03-10 21:02 ` Arnd Bergmann
2021-03-11 21:22 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210310193246.GA2033984@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.