From: Fenghua Yu <fenghua.yu@intel.com>
To: "Shuah Khan" <shuah@kernel.org>,
"Tony Luck" <tony.luck@intel.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
"Babu Moger" <babu.moger@amd.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>
Cc: "linux-kselftest" <linux-kselftest@vger.kernel.org>,
"linux-kernel" <linux-kernel@vger.kernel.org>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: [PATCH v6 12/21] selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported
Date: Wed, 17 Mar 2021 02:22:46 +0000 [thread overview]
Message-ID: <20210317022255.2536745-13-fenghua.yu@intel.com> (raw)
In-Reply-To: <20210317022255.2536745-1-fenghua.yu@intel.com>
check_resctrlfs_support() does the following
1. Checks if the platform supports resctrl file system or not by looking
for resctrl in /proc/filesystems
2. Calls opendir() on default resctrl file system path
(i.e. /sys/fs/resctrl)
3. Checks if resctrl file system is mounted or not by looking at
/proc/mounts
Steps 2 and 3 will fail if the platform does not support resctrl file
system. So, there is no need to check for them if step 1 fails.
Fix this by returning immediately if the platform does not support
resctrl file system.
Tested-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
tools/testing/selftests/resctrl/resctrlfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tools/testing/selftests/resctrl/resctrlfs.c b/tools/testing/selftests/resctrl/resctrlfs.c
index 6b22a186790a..87195eb78356 100644
--- a/tools/testing/selftests/resctrl/resctrlfs.c
+++ b/tools/testing/selftests/resctrl/resctrlfs.c
@@ -570,6 +570,9 @@ bool check_resctrlfs_support(void)
ksft_print_msg("%s kernel supports resctrl filesystem\n",
ret ? "Pass:" : "Fail:");
+ if (!ret)
+ return ret;
+
dp = opendir(RESCTRL_PATH);
ksft_print_msg("%s resctrl mountpoint \"%s\" exists\n",
dp ? "Pass:" : "Fail:", RESCTRL_PATH);
--
2.31.0
next prev parent reply other threads:[~2021-03-17 2:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 2:22 [PATCH v6 00/21] Miscellaneous fixes for resctrl selftests Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 01/21] selftests/resctrl: Enable gcc checks to detect buffer overflows Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 02/21] selftests/resctrl: Fix compilation issues for global variables Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 03/21] selftests/resctrl: Fix compilation issues for other " Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 04/21] selftests/resctrl: Clean up resctrl features check Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 05/21] selftests/resctrl: Ensure sibling CPU is not same as original CPU Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 06/21] selftests/resctrl: Fix missing options "-n" and "-p" Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 07/21] selftests/resctrl: Rename CQM test as CMT test Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 08/21] selftests/resctrl: Call kselftest APIs to log test results Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 09/21] selftests/resctrl: Share show_cache_info() by CAT and CMT tests Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 10/21] selftests/resctrl: Fix a printed message Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 11/21] selftests/resctrl: Add config dependencies Fenghua Yu
2021-03-17 2:22 ` Fenghua Yu [this message]
2021-04-02 19:48 ` [PATCH v6 12/21] selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported Shuah Khan
2021-03-17 2:22 ` [PATCH v6 13/21] selftests/resctrl: Use resctrl/info for feature detection Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 14/21] selftests/resctrl: Fix MBA/MBM results reporting format Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 15/21] selftests/resctrl: Don't hard code value of "no_of_bits" variable Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 16/21] selftests/resctrl: Modularize resctrl test suite main() function Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 17/21] selftests/resctrl: Skip the test if requested resctrl feature is not supported Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 18/21] selftests/resctrl: Fix unmount resctrl FS Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 19/21] selftests/resctrl: Fix incorrect parsing of iMC counters Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 20/21] selftests/resctrl: Fix checking for < 0 for unsigned values Fenghua Yu
2021-03-17 2:22 ` [PATCH v6 21/21] selftests/resctrl: Create .gitignore to include resctrl_tests Fenghua Yu
2021-03-26 19:45 ` [PATCH v6 00/21] Miscellaneous fixes for resctrl selftests Fenghua Yu
2021-04-02 18:17 ` Shuah Khan
2021-04-02 18:18 ` Fenghua Yu
2021-04-02 20:04 ` Shuah Khan
2021-04-02 21:07 ` Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210317022255.2536745-13-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=babu.moger@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=shuah@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.