All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
	Sathya Prakash <sathya.prakash@broadcom.com>,
	Sreekanth Reddy <sreekanth.reddy@broadcom.com>,
	Suganath Prabu Subramani  <suganath-prabu.subramani@broadcom.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	MPT-FusionLinux.pdl@avagotech.com,
	MPT-FusionLinux.pdl@broadcom.com, linux-scsi@vger.kernel.org
Subject: [PATCH 14/36] scsi: mpt3sas: mpt3sas_scs: Fix a few kernel-doc issues
Date: Wed, 17 Mar 2021 09:12:08 +0000	[thread overview]
Message-ID: <20210317091230.2912389-15-lee.jones@linaro.org> (raw)
In-Reply-To: <20210317091230.2912389-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/mpt3sas/mpt3sas_scsih.c:763: warning: Function parameter or member 'sas_address' not described in '__mpt3sas_get_sdev_by_addr'
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:763: warning: expecting prototype for mpt3sas_get_sdev_by_addr(). Prototype was for __mpt3sas_get_sdev_by_addr() instead
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:4535: warning: expecting prototype for _scsih_check_for_pending_internal_cmds(). Prototype was for mpt3sas_check_for_pending_internal_cmds() instead
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'port_entry' not described in '_scsih_look_and_get_matched_port_entry'
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'matched_port_entry' not described in '_scsih_look_and_get_matched_port_entry'
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:6188: warning: Function parameter or member 'count' not described in '_scsih_look_and_get_matched_port_entry'
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:6959: warning: Function parameter or member 'port' not described in 'mpt3sas_expander_remove'
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:10494: warning: expecting prototype for mpt3sas_scsih_reset_handler(). Prototype was for mpt3sas_scsih_pre_reset_handler() instead
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:10536: warning: expecting prototype for mpt3sas_scsih_reset_handler(). Prototype was for mpt3sas_scsih_reset_done_handler() instead
 drivers/scsi/mpt3sas/mpt3sas_scsih.c:12303: warning: expecting prototype for scsih__ncq_prio_supp(). Prototype was for scsih_ncq_prio_supp() instead

Cc: Sathya Prakash <sathya.prakash@broadcom.com>
Cc: Sreekanth Reddy <sreekanth.reddy@broadcom.com>
Cc: Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: MPT-FusionLinux.pdl@avagotech.com
Cc: MPT-FusionLinux.pdl@broadcom.com
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/scsi/mpt3sas/mpt3sas_scsih.c | 18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
index 945531e94d7e4..23ecf2750ec79 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c
@@ -749,9 +749,10 @@ __mpt3sas_get_sdev_by_rphy(struct MPT3SAS_ADAPTER *ioc,
 }
 
 /**
- * mpt3sas_get_sdev_by_addr - get _sas_device object corresponding to provided
+ * __mpt3sas_get_sdev_by_addr - get _sas_device object corresponding to provided
  *				sas address from sas_device_list list
  * @ioc: per adapter object
+ * @sas_address: device sas address
  * @port: port number
  *
  * Search for _sas_device object corresponding to provided sas address,
@@ -4518,7 +4519,7 @@ _scsih_issue_delayed_sas_io_unit_ctrl(struct MPT3SAS_ADAPTER *ioc,
 }
 
 /**
- * _scsih_check_for_pending_internal_cmds - check for pending internal messages
+ * mpt3sas_check_for_pending_internal_cmds - check for pending internal messages
  * @ioc: per adapter object
  * @smid: system request message index
  *
@@ -6174,10 +6175,10 @@ enum hba_port_matched_codes {
  * _scsih_look_and_get_matched_port_entry - Get matched hba port entry
  *					from HBA port table
  * @ioc: per adapter object
- * @port_entry - hba port entry from temporary port table which needs to be
+ * @port_entry: hba port entry from temporary port table which needs to be
  *		searched for matched entry in the HBA port table
- * @matched_port_entry - save matched hba port entry here
- * @count - count of matched entries
+ * @matched_port_entry: save matched hba port entry here
+ * @count: count of matched entries
  *
  * return type of matched entry found.
  */
@@ -6952,6 +6953,7 @@ _scsih_expander_add(struct MPT3SAS_ADAPTER *ioc, u16 handle)
  * mpt3sas_expander_remove - removing expander object
  * @ioc: per adapter object
  * @sas_address: expander sas_address
+ * @port: hba port entry
  */
 void
 mpt3sas_expander_remove(struct MPT3SAS_ADAPTER *ioc, u64 sas_address,
@@ -10487,7 +10489,7 @@ _scsih_scan_for_devices_after_reset(struct MPT3SAS_ADAPTER *ioc)
 }
 
 /**
- * mpt3sas_scsih_reset_handler - reset callback handler (for scsih)
+ * mpt3sas_scsih_pre_reset_handler - reset callback handler (for scsih)
  * @ioc: per adapter object
  *
  * The handler for doing any required cleanup or initialization.
@@ -10528,7 +10530,7 @@ mpt3sas_scsih_clear_outstanding_scsi_tm_commands(struct MPT3SAS_ADAPTER *ioc)
 }
 
 /**
- * mpt3sas_scsih_reset_handler - reset callback handler (for scsih)
+ * mpt3sas_scsih_reset_done_handler - reset callback handler (for scsih)
  * @ioc: per adapter object
  *
  * The handler for doing any required cleanup or initialization.
@@ -12295,7 +12297,7 @@ scsih_pci_mmio_enabled(struct pci_dev *pdev)
 }
 
 /**
- * scsih__ncq_prio_supp - Check for NCQ command priority support
+ * scsih_ncq_prio_supp - Check for NCQ command priority support
  * @sdev: scsi device struct
  *
  * This is called when a user indicates they would like to enable
-- 
2.27.0


  parent reply	other threads:[~2021-03-17  9:14 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-17  9:11 [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI Lee Jones
2021-03-17  9:11 ` Lee Jones
2021-03-17  9:11 ` [PATCH 01/36] scsi: myrb: Demote non-conformant kernel-doc headers and fix others Lee Jones
2021-03-17  9:11 ` [PATCH 02/36] scsi: ipr: Fix incorrect function names in their headers Lee Jones
2021-03-17  9:11 ` [PATCH 03/36] scsi: mvumi: Fix formatting and doc-rot issues Lee Jones
2021-03-17  9:11 ` [PATCH 04/36] scsi: sd_zbc: Place function name into header Lee Jones
2021-03-17  9:11 ` [PATCH 05/36] scsi: pmcraid: Fix a whole host of kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 06/36] scsi: sd: Fix function name in header Lee Jones
2021-03-17  9:12 ` [PATCH 07/36] scsi: aic94xx: aic94xx_dump: Correct misspelling of function asd_dump_seq_state() Lee Jones
2021-03-17  9:12 ` [PATCH 08/36] scsi: be2iscsi: be_main: Ensure function follows directly after its header Lee Jones
2021-03-17  9:12 ` [PATCH 09/36] scsi: dc395x: Fix some function param descriptions Lee Jones
2021-03-17  9:12 ` [PATCH 10/36] scsi: initio: Fix a few kernel-doc misdemeanours Lee Jones
2021-03-17  9:12 ` [PATCH 11/36] scsi: a100u2w: Fix some misnaming and formatting issues Lee Jones
2021-03-17  9:12 ` [PATCH 12/36] scsi: myrs: Add missing ':' to make the kernel-doc checker happy Lee Jones
2021-03-17  9:12 ` [PATCH 13/36] scsi: pmcraid: Correct function name pmcraid_show_adapter_id() in header Lee Jones
2021-03-17  9:12 ` Lee Jones [this message]
2021-03-17  9:12 ` [PATCH 15/36] scsi: be2iscsi: be_main: Demote incomplete/non-conformant kernel-doc header Lee Jones
2021-03-17  9:12 ` [PATCH 16/36] scsi: isci: phy: Fix a few different kernel-doc related issues Lee Jones
2021-03-17  9:12 ` [PATCH 17/36] scsi: fnic: fnic_scsi: Demote non-conformant kernel-doc headers Lee Jones
2021-03-17  9:12 ` [PATCH 18/36] scsi: fnic: fnic_fcs: Kernel-doc headers must contain the function name Lee Jones
2021-03-17  9:12 ` [PATCH 19/36] scsi: isci: phy: Provide function name and demote non-conforming header Lee Jones
2021-03-17  9:12 ` [PATCH 20/36] scsi: isci: request: Fix a myriad of kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 21/36] scsi: isci: host: Fix bunch of kernel-doc related issues Lee Jones
2021-03-17  9:12 ` [PATCH 22/36] scsi: isci: task: Demote non-conformant header and remove superfluous param Lee Jones
2021-03-17  9:12 ` [PATCH 23/36] scsi: isci: remote_node_table: Fix a bunch of kernel-doc misdemeanours Lee Jones
2021-03-17  9:12 ` [PATCH 24/36] scsi: isci: remote_node_context: Fix one function header and demote a couple more Lee Jones
2021-03-17  9:12 ` [PATCH 25/36] scsi: isci: port_config: Fix a bunch of doc-rot and demote abuses Lee Jones
2021-03-17  9:12 ` [PATCH 26/36] scsi: isci: remote_device: Fix a bunch of doc-rot issues Lee Jones
2021-03-17  9:12 ` [PATCH 27/36] scsi: isci: request: Fix doc-rot issue relating to 'ireq' param Lee Jones
2021-03-17  9:12 ` [PATCH 28/36] scsi: isci: port: Fix a bunch of kernel-doc issues Lee Jones
2021-03-17  9:12 ` [PATCH 29/36] scsi: isci: remote_node_context: Demote kernel-doc abuse Lee Jones
2021-03-17  9:12 ` [PATCH 30/36] scsi: isci: remote_node_table: Provide some missing params and remove others Lee Jones
2021-03-17  9:12 ` [PATCH 31/36] scsi: cxlflash: main: Fix a little do-rot Lee Jones
2021-03-17  9:12 ` [PATCH 32/36] scsi: cxlflash: superpipe: Fix a few misnaming issues Lee Jones
2021-03-17  9:12 ` [PATCH 33/36] scsi: ibmvscsi: Fix a bunch of kernel-doc related issues Lee Jones
2021-03-17  9:12   ` Lee Jones
2021-03-17  9:12 ` [PATCH 34/36] scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation Lee Jones
2021-03-17  9:12   ` Lee Jones
2021-03-17  9:12 ` [PATCH 35/36] scsi: ibmvscsi_tgt: ibmvscsi_tgt: Remove duplicate section 'NOTE' Lee Jones
2021-03-17  9:12 ` [PATCH 36/36] scsi: cxlflash: vlun: Fix some misnaming related doc-rot Lee Jones
2021-03-19  3:41 ` [PATCH 00/36] [Set 4] Rid W=1 warnings in SCSI Martin K. Petersen
2021-03-19  3:41   ` Martin K. Petersen
2021-03-19  8:10   ` Lee Jones
2021-03-19  8:10     ` Lee Jones
2021-03-25  3:53 ` Martin K. Petersen
2021-03-25  3:53   ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210317091230.2912389-15-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=MPT-FusionLinux.pdl@avagotech.com \
    --cc=MPT-FusionLinux.pdl@broadcom.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sathya.prakash@broadcom.com \
    --cc=sreekanth.reddy@broadcom.com \
    --cc=suganath-prabu.subramani@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.