Re: [Intel-gfx] [PATCH v2 09/14] drm/i915/bios: add i915 backpointer to intel_bios_encoder_data

From: Lucas De Marchi <lucas.demarchi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] [PATCH v2 09/14] drm/i915/bios: add i915 backpointer to intel_bios_encoder_data
Date: Wed, 17 Mar 2021 12:32:07 -0700	[thread overview]
Message-ID: <20210317193207.xpdiucxnym7rje2r@ldmartin-desk2> (raw)
In-Reply-To: <026b737b122273d256f4247e9b0c84529aa391fd.1615998927.git.jani.nikula@intel.com>

On Wed, Mar 17, 2021 at 06:36:48PM +0200, Jani Nikula wrote:
>We'll be needing it in the future.
>
>Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>---
> drivers/gpu/drm/i915/display/intel_bios.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
>index 7379cbb6c419..40fd60acd548 100644
>--- a/drivers/gpu/drm/i915/display/intel_bios.c
>+++ b/drivers/gpu/drm/i915/display/intel_bios.c
>@@ -60,6 +60,8 @@
>
> /* Wrapper for VBT child device config */
> struct intel_bios_encoder_data {
>+	struct drm_i915_private *i915;
>+
> 	struct child_device_config child;
> 	struct dsc_compression_parameters_entry *dsc;
> 	struct list_head node;
>@@ -2026,6 +2028,8 @@ parse_general_definitions(struct drm_i915_private *i915,
> 		if (!devdata)
> 			break;
>
>+		devdata->i915 = i915;
>+
> 		/*
> 		 * Copy as much as we know (sizeof) and is available
> 		 * (child_dev_size) of the child device config. Accessing the
>@@ -2103,6 +2107,7 @@ init_vbt_missing_defaults(struct drm_i915_private *i915)
> 		if (!devdata)
> 			break;
>
>+		devdata->i915 = i915;

maybe in the next common field it's time to introduce a _alloc()
function


Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>

Lucas De Marchi

> 		child = &devdata->child;
>
> 		if (port == PORT_F)
>-- 
>2.20.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx